Re: [PULL 33/41] KVM: PPC: Book3S: Move KVM_REG_PPC_WORT to an unused register number

Alexander Graf
2014-05-30T16:14:33Z

On 30.05.14 18:11, Paolo Bonzini wrote:
> Il 30/05/2014 18:08, Alexander Graf ha scritto:
>>> What happens if it returns EINVAL? Also, reset should certainly
>>> try to write all registers, what happens if one is missed.
>>
>> If it returns EINVAL we just ignore the register.
>
> I wonder if it's the right thing to do. You remember how you were
> bitten by less-than-sensible error handling in the x86
> kvm_arch_put_registers.

Yeah, I think we'll have to do a flag day as of which we declare PPC as
a first class supported citizen. At that point we'll have compat machine
types and start to do more intense error checking.

Alex