From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PULL 33/41] KVM: PPC: Book3S: Move KVM_REG_PPC_WORT to an unused register number Date: Fri, 30 May 2014 18:11:21 +0200 Message-ID: <5388ADA9.3080006@redhat.com> References: <1401453776-55285-1-git-send-email-agraf@suse.de> <1401453776-55285-34-git-send-email-agraf@suse.de> <5388A8DF.9050300@redhat.com> <5388A996.8010606@suse.de> <5388A9F6.5090301@redhat.com> <5388AA95.8050003@suse.de> <5388ABBE.3000704@redhat.com> <5388AD02.8010304@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com, Paul Mackerras To: Alexander Graf , kvm-ppc@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42489 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964826AbaE3QL2 (ORCPT ); Fri, 30 May 2014 12:11:28 -0400 In-Reply-To: <5388AD02.8010304@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Il 30/05/2014 18:08, Alexander Graf ha scritto: >> What happens if it returns EINVAL? Also, reset should certainly >> try to write all registers, what happens if one is missed. > > If it returns EINVAL we just ignore the register. I wonder if it's the right thing to do. You remember how you were bitten by less-than-sensible error handling in the x86 kvm_arch_put_registers. >> Beyond the particular case of WORT, I'd just like to point out that >> uapi/ changes need even more scrutiny from maintainers than usual. I >> don't know exactly what checks Linus makes in my pull requests, but >> uapi/ is at the top of the list of things he might look at, right >> after the diffstat. :) > > Consider that ONE_REG as experimental flagged :). Really, I am as > concerned as you are on ABI breakages, but in this case it's not worth > it. I'm not even sure any guest uses WORT at all. Linux doesn't seem to. Fair enough... for this time only!... Paolo