From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PULL 33/41] KVM: PPC: Book3S: Move KVM_REG_PPC_WORT to an unused register number Date: Fri, 30 May 2014 18:14:33 +0200 Message-ID: <5388AE69.2040206@suse.de> References: <1401453776-55285-1-git-send-email-agraf@suse.de> <1401453776-55285-34-git-send-email-agraf@suse.de> <5388A8DF.9050300@redhat.com> <5388A996.8010606@suse.de> <5388A9F6.5090301@redhat.com> <5388AA95.8050003@suse.de> <5388ABBE.3000704@redhat.com> <5388AD02.8010304@suse.de> <5388ADA9.3080006@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com, Paul Mackerras To: Paolo Bonzini , kvm-ppc@vger.kernel.org Return-path: In-Reply-To: <5388ADA9.3080006@redhat.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 30.05.14 18:11, Paolo Bonzini wrote: > Il 30/05/2014 18:08, Alexander Graf ha scritto: >>> What happens if it returns EINVAL? Also, reset should certainly >>> try to write all registers, what happens if one is missed. >> >> If it returns EINVAL we just ignore the register. > > I wonder if it's the right thing to do. You remember how you were > bitten by less-than-sensible error handling in the x86 > kvm_arch_put_registers. Yeah, I think we'll have to do a flag day as of which we declare PPC as a first class supported citizen. At that point we'll have compat machine types and start to do more intense error checking. Alex