From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Graf <agraf@suse.de>
Subject: Re: [RFC 0/2] GET_EMULATED_CPUID support with "allow-emulation" option
Date: Thu, 05 Jun 2014 18:24:22 +0200
Message-ID: <539099B6.2090000@suse.de>
References: <1401984741-26882-1-git-send-email-ehabkost@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Borislav Petkov <bp@alien8.de>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Gabriel L. Somlo" <gsomlo@gmail.com>, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Michael Mueller <mimu@linux.vnet.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
	=?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:36609 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751140AbaFEQY0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 5 Jun 2014 12:24:26 -0400
In-Reply-To: <1401984741-26882-1-git-send-email-ehabkost@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


On 05.06.14 18:12, Eduardo Habkost wrote:
> This implements GET_SUPPORTED_CPUID support using an explicit option for it:
> "allow-emulation". We don't want any emulated feature to be enabled by accident,
> so they will be enabled only if the user explicitly wants to allow them.

So is this an all-or-nothing approach? I would really prefer to override 
individual bits.

Also, I don't think the line "emulated" is the right one to draw. We 
"emulate" SVM or VMX too, but still enable them by default as soon as we 
think they're ready enough.

So could we add a new flag specifier instead? Today we have -flag and 
+flag. How about *flag to "force enable if the kernel can handle it, but 
doesn't do so by default"?


Alex