From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [RFC 0/2] GET_EMULATED_CPUID support with "allow-emulation" option
Date: Thu, 05 Jun 2014 19:39:42 +0200
Message-ID: <5390AB5E.5070702@redhat.com>
References: <1401984741-26882-1-git-send-email-ehabkost@redhat.com> <539099B6.2090000@suse.de> <53909A41.1060800@redhat.com> <53909D79.1070609@suse.de> <53909E53.9050300@redhat.com> <53909E9C.6080009@suse.de> <5390A06A.9070200@redhat.com> <5390A0B6.8050000@suse.de> <5390A195.4000003@redhat.com> <20140605171908.GO17594@otherpad.lan.raisama.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org,
	Borislav Petkov <bp@alien8.de>,
	"Gabriel L. Somlo" <gsomlo@gmail.com>, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Michael Mueller <mimu@linux.vnet.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
	=?ISO-8859-1?Q?Andreas_?= =?ISO-8859-1?Q?F=E4rber?=
	<afaerber@suse.de>
To: Eduardo Habkost <ehabkost@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-qg0-f42.google.com ([209.85.192.42]:64870 "EHLO
	mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751889AbaFERjs (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 5 Jun 2014 13:39:48 -0400
Received: by mail-qg0-f42.google.com with SMTP id q107so2176546qgd.1
        for <kvm@vger.kernel.org>; Thu, 05 Jun 2014 10:39:47 -0700 (PDT)
In-Reply-To: <20140605171908.GO17594@otherpad.lan.raisama.net>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 05/06/2014 19:19, Eduardo Habkost ha scritto:
> On Thu, Jun 05, 2014 at 06:57:57PM +0200, Paolo Bonzini wrote:
>> Il 05/06/2014 18:54, Alexander Graf ha scritto:
>>>>
>>>> What about:
>>>>
>>>> - letting "-cpu foo,+emulatedfeature" just work
>>>>
>>>> - adding emulated=yes that blindly enables all emulated features
>>>>
>>>> - making "-cpu ...,check" prints a warning for emulated features
>>>> unless emulated=yes
>>>
>>> How about we remove the emulated=yes from this list? Then I'm happy :).
>>
>> So:
>>
>> - "-cpu foo" doesn't enable any emulated feature
>
> What if "foo" already has movbe in the CPU model definition?

It will be disabled.

>>
>> - "-cpu foo,+movbe" does
>
> What if I want movbe enabled if and only if it is _not_ emulated?

Pick a CPU model that has it.

> The whole point here is to never ever ever enable an emulated feature
> unless it was explicitly what the user wanted.

"+foo" could be enough.

> "nice and descriptive message" needs to be better specified. Messages on
> stderr are useless for management software.

I'm not sure this feature is for management software users.

Paolo