From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: Fix GSI number space limit Date: Fri, 06 Jun 2014 18:31:14 +0200 Message-ID: <5391ECD2.3060507@redhat.com> References: <1402058765-48921-1-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Alexander Graf , qemu-devel@nongnu.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49599 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751693AbaFFQbT (ORCPT ); Fri, 6 Jun 2014 12:31:19 -0400 In-Reply-To: <1402058765-48921-1-git-send-email-agraf@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Il 06/06/2014 14:46, Alexander Graf ha scritto: > KVM tells us the number of GSIs it can handle inside the kernel. That value is > basically KVM_MAX_IRQ_ROUTES. However when we try to set the GSI mapping table, > it checks for > > r = -EINVAL; > if (routing.nr >= KVM_MAX_IRQ_ROUTES) > goto out; > > erroring out even when we're only using all of the GSIs. To make sure we never > hit that limit, let's reduce the number of GSIs we get from KVM by one. > > Signed-off-by: Alexander Graf > --- > kvm-all.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kvm-all.c b/kvm-all.c > index 4e19eff..56a251b 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -938,7 +938,7 @@ void kvm_init_irq_routing(KVMState *s) > { > int gsi_count, i; > > - gsi_count = kvm_check_extension(s, KVM_CAP_IRQ_ROUTING); > + gsi_count = kvm_check_extension(s, KVM_CAP_IRQ_ROUTING) - 1; > if (gsi_count > 0) { > unsigned int gsi_bits, i; > > Applied, thanks! Paolo