Re: [PATCH v5 11/19] add minimal virtio support for devtree virtio-mmio

Christoffer Dall
2014-06-14T13:30:18Z

On Wed, Jun 11, 2014 at 04:01:26PM +0200, Andrew Jones wrote:
> Support the bare minimum of virtio to enable access to the virtio-mmio
> config space of a device. Currently this implementation must use a
> device tree to find the device.
>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> v5:
> - use same virtio struct names as kernel
> - no need to alloc a new virtio_config_ops for each virtio device
> - use ioremap
> v4:
> - split from the virtio-testdev patch
> - search a table to "discover" that the device must be DT/virtio-mmio,
> which doesn't change anything, but looks less hacky than comments
> saying the device must be DT/virtio-mmio...
> - manage own pool of virtio-mmio pre-allocated device structures in
> order to avoid needing access to the heap
> ---

Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>