Re: [PATCH v5 03/19] clean root dir of all x86-ness

Andrew Jones
2014-06-12T10:54:20Z

On Thu, Jun 12, 2014 at 12:42:51PM +0200, Paolo Bonzini wrote:
> Il 12/06/2014 12:40, Andrew Jones ha scritto:
> >>>> >+if [ -z "$testdir" -a \( "$arch" = "i386" -o "$arch" = "x86_64" \) ]; then
> >>>> >+ testdir=x86
> >>>> >+elif [ -z "$testdir" ]; then
> >>>> >+ testdir=$arch
> >>>> >+fi
> >>>> >+if [ ! -d $testdir ]; then
> >>>> >+ echo "$testdir does not exist!"
> >>>> >+ exit 1
> >>>> >+fi
> >>>> >+if [ -f $testdir/run ]; then
> >>>> >+ ln -fs $testdir/run $testdir-run
> >>>> >+fi
> >>>
> >>> Why is --test-dir useful? Can you just use --arch instead?
> >testdir is not always the same as arch, e.g. arch=x86_64, testdir=x86,
> >and setting --arch x86 would lose useful information. We wouldn't know
> >if arch is supposed to be i386 or x86_64. The same argument will apply
> >to arch=arm vs. arch=aarch64.
> >
>
> Yes, testdir is useful indeed. But what is the usecase for --test-dir?
>

Ah, I misunderstood your question. Why the command line parameter? No
good reason. I was just creating the parameter to be consistent with the
other configuration options. I don't see any harm in keeping it, but I
also don't care if you'd prefer it go.

drew