From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
christoffer.dall@linaro.org
Subject: Re: [PATCH v5 03/19] clean root dir of all x86-ness
Date: Thu, 12 Jun 2014 12:42:51 +0200 [thread overview]
Message-ID: <5399842B.9090502@redhat.com> (raw)
In-Reply-To: <20140612104005.GA6646@dhcp-27-201.brq.redhat.com>
Il 12/06/2014 12:40, Andrew Jones ha scritto:
>>> > >+if [ -z "$testdir" -a \( "$arch" = "i386" -o "$arch" = "x86_64" \) ]; then
>>> > >+ testdir=x86
>>> > >+elif [ -z "$testdir" ]; then
>>> > >+ testdir=$arch
>>> > >+fi
>>> > >+if [ ! -d $testdir ]; then
>>> > >+ echo "$testdir does not exist!"
>>> > >+ exit 1
>>> > >+fi
>>> > >+if [ -f $testdir/run ]; then
>>> > >+ ln -fs $testdir/run $testdir-run
>>> > >+fi
>> >
>> > Why is --test-dir useful? Can you just use --arch instead?
> testdir is not always the same as arch, e.g. arch=x86_64, testdir=x86,
> and setting --arch x86 would lose useful information. We wouldn't know
> if arch is supposed to be i386 or x86_64. The same argument will apply
> to arch=arm vs. arch=aarch64.
>
Yes, testdir is useful indeed. But what is the usecase for --test-dir?
Paolo
next prev parent reply other threads:[~2014-06-12 10:42 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 14:01 [PATCH v5 00/19] kvm-unit-tests/arm: initial drop Andrew Jones
2014-06-11 14:01 ` [PATCH v5 01/19] remove unused files Andrew Jones
2014-06-11 14:01 ` [PATCH v5 02/19] makefile and run_tests tweaks Andrew Jones
2014-06-11 14:01 ` [PATCH v5 03/19] clean root dir of all x86-ness Andrew Jones
2014-06-12 10:31 ` Paolo Bonzini
2014-06-12 10:40 ` Andrew Jones
2014-06-12 10:42 ` Paolo Bonzini [this message]
2014-06-12 10:54 ` Andrew Jones
2014-06-11 14:01 ` [PATCH v5 04/19] add distclean target and gitignore more Andrew Jones
2014-06-12 10:36 ` Paolo Bonzini
2014-06-14 13:17 ` Christoffer Dall
2014-06-11 14:01 ` [PATCH v5 05/19] add 'make cscope' support Andrew Jones
2014-06-11 14:01 ` [PATCH v5 07/19] libfdt: get libfdt to build Andrew Jones
2014-06-11 14:01 ` [PATCH v5 08/19] add support for Linux device trees Andrew Jones
2014-06-12 9:19 ` Christoffer Dall
2014-06-11 14:01 ` [PATCH v5 09/19] libcflat: add abort() and assert() Andrew Jones
2014-06-12 10:48 ` Paolo Bonzini
2014-06-12 11:07 ` Andrew Jones
2014-06-12 11:09 ` Paolo Bonzini
2014-06-11 14:01 ` [PATCH v5 10/19] Introduce asm-generic/*.h files Andrew Jones
2014-06-11 14:01 ` [PATCH v5 11/19] add minimal virtio support for devtree virtio-mmio Andrew Jones
2014-06-14 13:30 ` Christoffer Dall
2014-06-11 14:01 ` [PATCH v5 12/19] Introduce virtio-testdev Andrew Jones
2014-06-12 10:16 ` Paolo Bonzini
2014-06-12 11:30 ` Andrew Jones
2014-06-12 11:56 ` Paolo Bonzini
2014-06-11 14:01 ` [PATCH v5 13/19] libcflat: clean up libcflat.h and add string.h Andrew Jones
2014-06-12 10:52 ` Paolo Bonzini
2014-06-12 11:12 ` Andrew Jones
2014-06-11 14:01 ` [PATCH v5 14/19] printf: support field padding Andrew Jones
2014-06-11 14:01 ` [PATCH v5 15/19] arm: initial drop Andrew Jones
2014-06-14 14:16 ` Christoffer Dall
2014-06-16 7:36 ` Andrew Jones
2014-06-11 14:01 ` [PATCH v5 16/19] arm: Add spinlock implementation Andrew Jones
2014-06-11 14:01 ` [PATCH v5 17/19] arm: Add IO accessors to avoid register-writeback Andrew Jones
2014-06-11 14:01 ` [PATCH v5 18/19] arm: add useful headers from the Linux kernel Andrew Jones
2014-06-11 14:01 ` [PATCH v5 19/19] arm: vectors support Andrew Jones
[not found] ` <1402495294-30737-7-git-send-email-drjones@redhat.com>
2014-06-12 10:44 ` [PATCH v5 06/19] libfdt: Import libfdt source Paolo Bonzini
2014-06-12 10:59 ` Andrew Jones
2014-06-12 14:39 ` Paolo Bonzini
2014-06-12 11:09 ` Paolo Bonzini
2014-06-12 10:54 ` [PATCH v5 00/19] kvm-unit-tests/arm: initial drop Paolo Bonzini
2014-06-14 14:44 ` Christoffer Dall
2014-06-16 7:46 ` Andrew Jones
2014-06-16 7:56 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5399842B.9090502@redhat.com \
--to=pbonzini@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox