From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v5 03/19] clean root dir of all x86-ness Date: Thu, 12 Jun 2014 12:42:51 +0200 Message-ID: <5399842B.9090502@redhat.com> References: <1402495294-30737-1-git-send-email-drjones@redhat.com> <1402495294-30737-4-git-send-email-drjones@redhat.com> <5399819A.2030007@redhat.com> <20140612104005.GA6646@dhcp-27-201.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer.dall@linaro.org To: Andrew Jones Return-path: Received: from mail-qc0-f180.google.com ([209.85.216.180]:59253 "EHLO mail-qc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932916AbaFLKmz (ORCPT ); Thu, 12 Jun 2014 06:42:55 -0400 Received: by mail-qc0-f180.google.com with SMTP id i17so1632007qcy.11 for ; Thu, 12 Jun 2014 03:42:55 -0700 (PDT) In-Reply-To: <20140612104005.GA6646@dhcp-27-201.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 12/06/2014 12:40, Andrew Jones ha scritto: >>> > >+if [ -z "$testdir" -a \( "$arch" = "i386" -o "$arch" = "x86_64" \) ]; then >>> > >+ testdir=x86 >>> > >+elif [ -z "$testdir" ]; then >>> > >+ testdir=$arch >>> > >+fi >>> > >+if [ ! -d $testdir ]; then >>> > >+ echo "$testdir does not exist!" >>> > >+ exit 1 >>> > >+fi >>> > >+if [ -f $testdir/run ]; then >>> > >+ ln -fs $testdir/run $testdir-run >>> > >+fi >> > >> > Why is --test-dir useful? Can you just use --arch instead? > testdir is not always the same as arch, e.g. arch=x86_64, testdir=x86, > and setting --arch x86 would lose useful information. We wouldn't know > if arch is supposed to be i386 or x86_64. The same argument will apply > to arch=arm vs. arch=aarch64. > Yes, testdir is useful indeed. But what is the usecase for --test-dir? Paolo