From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: kvm <kvm@vger.kernel.org>, Bandan Das <bsd@redhat.com>
Subject: Re: [PATCH 0/5] KVM: nVMX: Small fixes improving emulation accuracy
Date: Mon, 16 Jun 2014 12:44:57 +0200 [thread overview]
Message-ID: <539ECAA9.9090204@redhat.com> (raw)
In-Reply-To: <cover.1402841929.git.jan.kiszka@web.de>
Il 15/06/2014 16:18, Jan Kiszka ha scritto:
> Nothing critical, but it further improves emulation accuracy,
> specifically helpful when analyzing guest bugs...
>
> Corresponding kvm-unit-tests will be provided.
>
> Jan Kiszka (5):
> KVM: nVMX: Fix returned value of MSR_IA32_VMX_PROCBASED_CTLS
> KVM: nVMX: Advertise support for MSR_IA32_VMX_TRUE_*_CTLS
> KVM: nVMX: Allow to disable CR3 access interception
> KVM: nVMX: Allow to disable VM_{ENTRY_LOAD,EXIT_SAVE}_DEBUG_CONTROLS
> KVM: nVMX: Fix returned value of MSR_IA32_VMX_VMCS_ENUM
>
> arch/x86/include/asm/vmx.h | 3 ++
> arch/x86/include/uapi/asm/msr-index.h | 1 +
> arch/x86/kvm/vmx.c | 75 +++++++++++++++++++++++++----------
> 3 files changed, 58 insertions(+), 21 deletions(-)
If you reorder the first three patches as 2 then 3 then 1, you do not
need to temporarily break CR3 access interception. There is no
conflict, just changes in the context. Does that look good to you?
I had a minor comment on patch 4.
Paolo
next prev parent reply other threads:[~2014-06-16 10:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-15 14:18 [PATCH 0/5] KVM: nVMX: Small fixes improving emulation accuracy Jan Kiszka
2014-06-15 14:18 ` [PATCH 1/5] KVM: nVMX: Fix returned value of MSR_IA32_VMX_PROCBASED_CTLS Jan Kiszka
2014-06-15 14:18 ` [PATCH 2/5] KVM: nVMX: Advertise support for MSR_IA32_VMX_TRUE_*_CTLS Jan Kiszka
2014-06-15 14:18 ` [PATCH 3/5] KVM: nVMX: Allow to disable CR3 access interception Jan Kiszka
2014-06-15 14:18 ` [PATCH 4/5] KVM: nVMX: Allow to disable VM_{ENTRY_LOAD,EXIT_SAVE}_DEBUG_CONTROLS Jan Kiszka
2014-06-16 10:43 ` Paolo Bonzini
2014-06-15 14:18 ` [PATCH 5/5] KVM: nVMX: Fix returned value of MSR_IA32_VMX_VMCS_ENUM Jan Kiszka
2014-06-16 10:44 ` Paolo Bonzini [this message]
2014-06-16 11:25 ` [PATCH 0/5] KVM: nVMX: Small fixes improving emulation accuracy Jan Kiszka
2014-06-16 11:33 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539ECAA9.9090204@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox