From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 0/5] KVM: nVMX: Small fixes improving emulation accuracy Date: Mon, 16 Jun 2014 12:44:57 +0200 Message-ID: <539ECAA9.9090204@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm , Bandan Das To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:2490 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755104AbaFPKpB (ORCPT ); Mon, 16 Jun 2014 06:45:01 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Il 15/06/2014 16:18, Jan Kiszka ha scritto: > Nothing critical, but it further improves emulation accuracy, > specifically helpful when analyzing guest bugs... > > Corresponding kvm-unit-tests will be provided. > > Jan Kiszka (5): > KVM: nVMX: Fix returned value of MSR_IA32_VMX_PROCBASED_CTLS > KVM: nVMX: Advertise support for MSR_IA32_VMX_TRUE_*_CTLS > KVM: nVMX: Allow to disable CR3 access interception > KVM: nVMX: Allow to disable VM_{ENTRY_LOAD,EXIT_SAVE}_DEBUG_CONTROLS > KVM: nVMX: Fix returned value of MSR_IA32_VMX_VMCS_ENUM > > arch/x86/include/asm/vmx.h | 3 ++ > arch/x86/include/uapi/asm/msr-index.h | 1 + > arch/x86/kvm/vmx.c | 75 +++++++++++++++++++++++++---------- > 3 files changed, 58 insertions(+), 21 deletions(-) If you reorder the first three patches as 2 then 3 then 1, you do not need to temporarily break CR3 access interception. There is no conflict, just changes in the context. Does that look good to you? I had a minor comment on patch 4. Paolo