From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/5] VMX: Add tests for CR3 and CR8 interception
Date: Mon, 16 Jun 2014 12:53:00 +0200
Message-ID: <539ECC8C.6010605@redhat.com>
References: <cover.1402842281.git.jan.kiszka@web.de> <ba4586ec66995eb0b3628f2073a4086bf44b26fc.1402842281.git.jan.kiszka@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm <kvm@vger.kernel.org>, Bandan Das <bsd@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:27967 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752233AbaFPKxD (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 16 Jun 2014 06:53:03 -0400
In-Reply-To: <ba4586ec66995eb0b3628f2073a4086bf44b26fc.1402842281.git.jan.kiszka@web.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 15/06/2014 16:24, Jan Kiszka ha scritto:
> +++ b/x86/vmx_tests.c
> @@ -820,8 +820,8 @@ static int iobmp_exit_handler()
>  #define INSN_ALWAYS_TRAP	2
>  #define INSN_NEVER_TRAP		3
>
> -#define FIELD_EXIT_QUAL		0
> -#define FIELD_INSN_INFO		1
> +#define FIELD_EXIT_QUAL		0x1
> +#define FIELD_INSN_INFO		0x2

Small nit, using (1 << 0) and (1 << 1) would have reminded better this 
lazy maintainer that these fields form a bitmask. :)

Paolo

>
>  asm(