Re: [PATCH 0/5] KVM: nVMX: Small fixes improving emulation accuracy

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2014-06-16 12:44, Paolo Bonzini wrote:
> Il 15/06/2014 16:18, Jan Kiszka ha scritto:
>> Nothing critical, but it further improves emulation accuracy,
>> specifically helpful when analyzing guest bugs...
>>
>> Corresponding kvm-unit-tests will be provided.
>>
>> Jan Kiszka (5):
>>   KVM: nVMX: Fix returned value of MSR_IA32_VMX_PROCBASED_CTLS
>>   KVM: nVMX: Advertise support for MSR_IA32_VMX_TRUE_*_CTLS
>>   KVM: nVMX: Allow to disable CR3 access interception
>>   KVM: nVMX: Allow to disable VM_{ENTRY_LOAD,EXIT_SAVE}_DEBUG_CONTROLS
>>   KVM: nVMX: Fix returned value of MSR_IA32_VMX_VMCS_ENUM
>>
>>  arch/x86/include/asm/vmx.h            |  3 ++
>>  arch/x86/include/uapi/asm/msr-index.h |  1 +
>>  arch/x86/kvm/vmx.c                    | 75
>> +++++++++++++++++++++++++----------
>>  3 files changed, 58 insertions(+), 21 deletions(-)
> 
> If you reorder the first three patches as 2 then 3 then 1, you do not
> need to temporarily break CR3 access interception.  There is no
> conflict, just changes in the context.  Does that look good to you?

Fine with me, but I guess I should adjust some commit message(s)
accordingly. Resend?

> 
> I had a minor comment on patch 4.

Which is fine with me.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux