From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 00/23] MIPS: KVM: Fixes and guest timer rewrite Date: Mon, 16 Jun 2014 18:33:20 +0200 Message-ID: <539F1C50.3090604@redhat.com> References: <1401355005-20370-1-git-send-email-james.hogan@imgtec.com> <53870DAD.7050900@redhat.com> <53874719.5070604@imgtec.com> <538750F8.7040202@redhat.com> <53875FEE.1020607@imgtec.com> <53876850.20600@redhat.com> <53879C3E.3040102@imgtec.com> <538839DE.3000804@redhat.com> <539F1B76.8090601@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Andreas Herrmann , Gleb Natapov , kvm@vger.kernel.org, Ralf Baechle , linux-mips@linux-mips.org, David Daney , Sanjay Lal To: James Hogan Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49838 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754714AbaFPQem (ORCPT ); Mon, 16 Jun 2014 12:34:42 -0400 In-Reply-To: <539F1B76.8090601@imgtec.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 16/06/2014 18:29, James Hogan ha scritto: >> Rather than adding comments, we might as well force it to be always zero >> and just write get_clock() to COUNT_RESUME. >> >> Finally, having to serialize env->count_save_time makes harder to >> support migration from TCG to KVM and back. > > Yes, I'm not keen on that bit of code. Are you going to submit it for 2.1? There are still a few days for review and inclusion. Paolo