From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2 3/5] KVM: nVMX: Fix returned value of MSR_IA32_VMX_PROCBASED_CTLS Date: Tue, 17 Jun 2014 08:14:25 +0200 Message-ID: <539FDCC1.7080103@web.de> References: <9c25dd5a8d9392743b77d904364fa99695e4db5b.1402919981.git.jan.kiszka@siemens.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Gp1OIWUaqxTPrrD32GAtOh9c7da2kPKFd" Cc: Paolo Bonzini , kvm To: Bandan Das Return-path: Received: from mout.web.de ([212.227.15.3]:54927 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932093AbaFQGO3 (ORCPT ); Tue, 17 Jun 2014 02:14:29 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Gp1OIWUaqxTPrrD32GAtOh9c7da2kPKFd Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2014-06-16 18:56, Bandan Das wrote: > Jan Kiszka writes: >=20 >> SDM says bits 1, 4-6, 8, 13-16, and 26 have to be set. >> >> Signed-off-by: Jan Kiszka >> --- >> arch/x86/include/asm/vmx.h | 3 +++ >> arch/x86/kvm/vmx.c | 5 +++-- >> 2 files changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h >> index d989829..bcbfade 100644 >> --- a/arch/x86/include/asm/vmx.h >> +++ b/arch/x86/include/asm/vmx.h >> @@ -51,6 +51,9 @@ >> #define CPU_BASED_MONITOR_EXITING 0x20000000 >> #define CPU_BASED_PAUSE_EXITING 0x40000000 >> #define CPU_BASED_ACTIVATE_SECONDARY_CONTROLS 0x80000000 >> + >> +#define CPU_BASED_ALWAYSON_WITHOUT_TRUE_MSR 0x0401e172 >> + >=20 > Nit: Do we want to keep this consistent ? The previous defines have spa= ces, > and you have introduced a tab Old code used spaces, recent additions tabs - well... Jan --Gp1OIWUaqxTPrrD32GAtOh9c7da2kPKFd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlOf3MIACgkQitSsb3rl5xSs+wCeJYKJoqUPnYrg2bYhuAFupJtY YNoAn3TZY6qxHH5TNjyHxheC/A0geo90 =1m6D -----END PGP SIGNATURE----- --Gp1OIWUaqxTPrrD32GAtOh9c7da2kPKFd--