From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH 6/6] kvm_stat: Add powerpc support Date: Wed, 18 Jun 2014 03:54:20 +0200 Message-ID: <53A0F14C.6010702@suse.de> References: <1402991675-24905-1-git-send-email-mpe@ellerman.id.au> <1402991675-24905-6-git-send-email-mpe@ellerman.id.au> <539FFC0C.6060105@suse.de> <1403052608.32307.1.camel@concordia> <53A0E489.1040901@suse.de> <1403055439.32307.2.camel@concordia> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, graalfs@linux.vnet.ibm.com, jfrei@linux.vnet.ibm.com, jan.kiszka@siemens.com, pbonzini@redhat.com, aik@ozlabs.ru To: Michael Ellerman Return-path: Received: from cantor2.suse.de ([195.135.220.15]:34723 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755104AbaFRByY (ORCPT ); Tue, 17 Jun 2014 21:54:24 -0400 In-Reply-To: <1403055439.32307.2.camel@concordia> Sender: kvm-owner@vger.kernel.org List-ID: On 18.06.14 03:37, Michael Ellerman wrote: > On Wed, 2014-06-18 at 02:59 +0200, Alexander Graf wrote: >> On 18.06.14 02:50, Michael Ellerman wrote: >>> On Tue, 2014-06-17 at 10:27 +0200, Alexander Graf wrote: >>>> On 17.06.14 09:54, Michael Ellerman wrote: >>>>> Add support for powerpc platforms. We use uname -m, which allows us to >>>>> detect ppc, ppc64 and ppc64le/el. >>>>> >>>>> Signed-off-by: Michael Ellerman >>>> Could you please add support for PR KVM tracepoints along the way? There >>>> we do know the exit reason for every single guest <-> host transition. I >>>> would like to move to a similar model with HV in the future, so we can >>>> hopefully just reuse this by then. >>> So I think what you're saying is you want it to somehow support using >>> 'kvm_exit' for PR and 'kvm_userspace_exit' for HV? >> "kvm_userspace_exit" is implemented on both HV and PR. "kvm_exit" is PR >> only, but I'm hoping we can get it working in HV as well. >> >>> Or actually use 'kvm_exit' if it exists and fall back to 'kvm_userspace_exit', >>> so that if HV starts providing 'kvm_exit' the script will pick that up without >>> further changes. >> They are completely different things. "kvm_userspace_exit" tells us >> which exits we take from KVM -> QEMU. "kvm_exit" tells us which exits we >> take from guest -> KVM. >> >> In fact, IIRC x86 also implements kvm_userspace_exit - or at least >> something very similar to it. It's a completely separate category. > Right. Everyone implements kvm_userspace_exit, it's in virt/kvm/kvm_main.c > >> Maybe it should be a command line switch to distinguish between the count types? > Or just we always read the kvm_userspace_exit counts, and if we find kvm_exit > we expose that as well - with an arch specific set of reasons. That would work too. I'm not sure how interesting the exit count of kvm_userspace_exit really is, but it certainly works for me to have it available as well. Alex