From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 9/9] KVM: vmx: vmx instructions handling does not consider cs.l Date: Wed, 18 Jun 2014 18:06:57 +0200 Message-ID: <53A1B921.1050108@redhat.com> References: <539F059F.8050501@redhat.com> <1403101166-23616-1-git-send-email-namit@cs.technion.ac.il> <1403101166-23616-10-git-send-email-namit@cs.technion.ac.il> <53A1B33A.3080509@redhat.com> <53A1B7EE.7070800@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Nadav Amit , Nadav Amit Return-path: In-Reply-To: <53A1B7EE.7070800@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 18/06/2014 18:01, Nadav Amit ha scritto: >> > > Perhaps I am missing something, but I don't see where my mistake is. > The VMREAD source operand is always read as 64-bits and I made no > changes there. Therefore, if bits 63:32 are not zero, the instruction > should fail when attempting to access the field. In 32-bit mode, it should be read as 32 bits: "Outside IA-32e mode, the source operand has 32 bits, regardless of the value of CS.D" (so it's never 16 bits, but it's also never 64 bits). Paolo