From: Paolo Bonzini <pbonzini@redhat.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Gleb Natapov <gleb@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch: x86: kvm: x86.c: Cleaning up variable is set more than once
Date: Wed, 25 Jun 2014 14:27:01 +0200 [thread overview]
Message-ID: <53AAC015.1060507@redhat.com> (raw)
In-Reply-To: <1403699158-22807-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Il 25/06/2014 14:25, Rickard Strandqvist ha scritto:
> A struct member variable is set to the same value more than once
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/x86/kvm/x86.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index f32a025..0f48eb7 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -4730,7 +4730,6 @@ static void emulator_set_segment(struct x86_emulate_ctxt *ctxt, u16 selector,
> if (desc->g)
> var.limit = (var.limit << 12) | 0xfff;
> var.type = desc->type;
> - var.present = desc->p;
> var.dpl = desc->dpl;
> var.db = desc->d;
> var.s = desc->s;
>
Thanks, applying this patch.
Paolo
prev parent reply other threads:[~2014-06-25 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 12:25 [PATCH] arch: x86: kvm: x86.c: Cleaning up variable is set more than once Rickard Strandqvist
2014-06-25 12:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AAC015.1060507@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rickard_strandqvist@spectrumdigital.se \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).