From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Daney Subject: Re: [PATCH v4 5/7] MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_" Date: Thu, 26 Jun 2014 14:55:35 -0700 Message-ID: <53AC96D7.8040208@gmail.com> References: <1403809900-17454-1-git-send-email-dengcheng.zhu@imgtec.com> <1403809900-17454-6-git-send-email-dengcheng.zhu@imgtec.com> <53AC7466.6070401@gmail.com> <53AC7AAD.7010007@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, gleb@kernel.org, kvm@vger.kernel.org, sanjayl@kymasys.com, james.hogan@imgtec.com, ralf@linux-mips.org, linux-mips@linux-mips.org To: Deng-Cheng Zhu Return-path: Received: from mail-ig0-f171.google.com ([209.85.213.171]:56087 "EHLO mail-ig0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbaFZVzi (ORCPT ); Thu, 26 Jun 2014 17:55:38 -0400 Received: by mail-ig0-f171.google.com with SMTP id h18so1260189igc.16 for ; Thu, 26 Jun 2014 14:55:37 -0700 (PDT) In-Reply-To: <53AC7AAD.7010007@imgtec.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/26/2014 12:55 PM, Deng-Cheng Zhu wrote: > On 06/26/2014 12:28 PM, David Daney wrote: >> On 06/26/2014 12:11 PM, Deng-Cheng Zhu wrote: >>> From: Deng-Cheng Zhu >>> >>> Since all the files are in arch/mips/kvm/, there's no need of the >>> prefixes >>> "kvm_" and "kvm_mips_". >>> >> >> I don't like this change. >> >> It will leads me to confuse arch/mips/kvm/interrupt.h with >> include/linux/interrupt.h > > We have and "interrupt.h". > >> >> x86 calls these things irq.c and irq.h, perhaps that would be a little >> better. > > There's also include/linux/irq.h > Yes, I know. >> >> There is precedence in x86 for some of the names though. >> >> But really why churn up the code in the first place? the kvm_mips >> prefix does tell us exactly what we are dealing with. > > That's why people created the arch/mips/kvm directory, isn't it? No. Segregating things into directories keeps code related to one functional area together. File names are different. They should carry as much meaning as possible. For examples of this look at some of these directories: drivers/net/ethernet/intel/ixgb drivers/i2c/busses It is not bad to have a filename prefix related to the function of the files. > > > Deng-Cheng > > >