From mboxrd@z Thu Jan  1 00:00:00 1970
From: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
Subject: Re: [PATCH v3 7/9] MIPS: KVM: Fix memory leak on VCPU
Date: Fri, 27 Jun 2014 16:47:20 -0700
Message-ID: <53AE0288.6000905@imgtec.com>
References: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com> <1403631071-6012-8-git-send-email-dengcheng.zhu@imgtec.com> <53AA9625.8020802@imgtec.com> <53AABDE9.3050907@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <gleb@kernel.org>, <kvm@vger.kernel.org>, <sanjayl@kymasys.com>,
	<ralf@linux-mips.org>, <linux-mips@linux-mips.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
	James Hogan <james.hogan@imgtec.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mailapp01.imgtec.com ([195.59.15.196]:4146 "EHLO
	mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751273AbaF0XrZ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 27 Jun 2014 19:47:25 -0400
In-Reply-To: <53AABDE9.3050907@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi Paolo,


On 06/25/2014 05:17 AM, Paolo Bonzini wrote:
> Il 25/06/2014 11:28, James Hogan ha scritto:
>> On 24/06/14 18:31, Deng-Cheng Zhu wrote:
>>> From: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
>>>
>>> kvm_arch_vcpu_free() is called in 2 code paths:
>>>
>>> 1) kvm_vm_ioctl()
>>>        kvm_vm_ioctl_create_vcpu()
>>>            kvm_arch_vcpu_destroy()
>>>                kvm_arch_vcpu_free()
>>> 2) kvm_put_kvm()
>>>        kvm_destroy_vm()
>>>            kvm_arch_destroy_vm()
>>>                kvm_mips_free_vcpus()
>>>                    kvm_arch_vcpu_free()
>>>
>>> Neither of the paths handles VCPU free. We need to do it in
>>> kvm_arch_vcpu_free() corresponding to the memory allocation in
>>> kvm_arch_vcpu_create().
>>>
>>> Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
>>
>> Reviewed-by: James Hogan <james.hogan@imgtec.com>
>>
>> Maybe worth adding "Cc: stable@vger.kernel.org" and moving this to the
>> beginning of the patchset to avoid conflicts.
>>
>> Cheers
>> James
>>
>
> I've queued this for 3.16.  It applies cleanly apart for the filename change.

Maybe you forgot to put this on the branch "queue"? I don't see it. Thanks.


Deng-Cheng