From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH] KVM: nSVM: Fix IOIO bitmap evaluation
Date: Mon, 30 Jun 2014 17:15:02 +0200
Message-ID: <53B17EF6.2080403@web.de>
References: <53B125B9.6050306@web.de> <53B17D5D.8030206@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="2uPUDI3JIW7697UmrbT1qbr3qQijk1aVL"
Cc: Joerg Roedel <joro@8bytes.org>,
	Valentine Sinitsyn <valentine.sinitsyn@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kvm <kvm@vger.kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mout.web.de ([212.227.17.12]:55926 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751015AbaF3PPM (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 30 Jun 2014 11:15:12 -0400
In-Reply-To: <53B17D5D.8030206@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--2uPUDI3JIW7697UmrbT1qbr3qQijk1aVL
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

On 2014-06-30 17:08, Paolo Bonzini wrote:
> Il 30/06/2014 10:54, Jan Kiszka ha scritto:
>> +        SVM_IOIO_SIZE_SHIFT;
>>      gpa  =3D svm->nested.vmcb_iopm + (port / 8);
>> -    bit  =3D port % 8;
>> -    val  =3D 0;
>> +    start_bit =3D port % 8;
>> +    iopm_len =3D (start_bit + size > 8) ? 2 : 1;
>> +    mask =3D (0xf >> (4 - size)) << start_bit;
>=20
> These two lines are tricky. :)

That last line was, indeed... :)

>=20
> The patch looks good, I'll write a test case if you don't beat me to it=
=2E

I'm not going to beat you if you write any test case. :)

Didn't check the svm part of the unit tests recently, if they are as
easily extensible for such scenarios like vmx is now.

Jan



--2uPUDI3JIW7697UmrbT1qbr3qQijk1aVL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlOxfvYACgkQitSsb3rl5xQUsQCeNyKecaD34wsbtf8ROOwdFfFq
K1oAoIdOwlGk2r2SNDcbXGtn1zQC+XUq
=T5GG
-----END PGP SIGNATURE-----

--2uPUDI3JIW7697UmrbT1qbr3qQijk1aVL--