From: Paolo Bonzini <pbonzini@redhat.com>
To: Will Deacon <will.deacon@arm.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
Gleb Natapov <gleb@kernel.org>,
Marc Zyngier <Marc.Zyngier@arm.com>,
Christoffer Dall <christoffer.dall@linaro.org>
Subject: Re: [PATCH 1/2] KVM: device: add simple registration mechanism for kvm_device_ops
Date: Mon, 30 Jun 2014 19:32:59 +0200 [thread overview]
Message-ID: <53B19F4B.2020701@redhat.com> (raw)
In-Reply-To: <20140630173115.GF30740@arm.com>
Il 30/06/2014 19:31, Will Deacon ha scritto:
>> > It would let Will keep the simpler code with an array, and autogenerate
>> > KVM_DEV_TYPE_MAX.
> Although this is uapi, so we may need to #define the symbols anyway to avoid
> breaking userspace #ifndef tests.
>
> What do you reckon; is this an ABI break?
Yes, it would be an API break. But you can also do this:
#define FOO FOO
I think there are other occurrences of this in uapi/.
Paolo
prev parent reply other threads:[~2014-06-30 17:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 17:30 [PATCH 1/2] KVM: device: add simple registration mechanism for kvm_device_ops Will Deacon
2014-06-26 17:30 ` [PATCH 2/2] KVM: ARM: vgic: register kvm_device_ops dynamically Will Deacon
2014-06-27 14:17 ` [PATCH 1/2] KVM: device: add simple registration mechanism for kvm_device_ops Paolo Bonzini
2014-06-30 11:11 ` Will Deacon
2014-06-30 11:14 ` Cornelia Huck
2014-06-30 11:20 ` Will Deacon
2014-06-30 9:21 ` Cornelia Huck
2014-06-30 9:36 ` Will Deacon
2014-06-30 10:25 ` Cornelia Huck
2014-06-30 10:26 ` Will Deacon
2014-06-30 17:22 ` Paolo Bonzini
2014-06-30 17:27 ` Cornelia Huck
2014-06-30 17:31 ` Will Deacon
2014-06-30 17:32 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B19F4B.2020701@redhat.com \
--to=pbonzini@redhat.com \
--cc=Marc.Zyngier@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox