From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: x86: Fix lapic.c debug prints Date: Mon, 30 Jun 2014 20:02:18 +0200 Message-ID: <53B1A62A.9070500@redhat.com> References: <1404034131-2392-1-git-send-email-namit@cs.technion.ac.il> <53B0B773.3030107@gmail.com> <53B1541E.4080008@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Nadav Amit , Nadav Amit , gleb@kernel.org, tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Bandan Das Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 30/06/2014 19:39, Bandan Das ha scritto: > Paolo Bonzini writes: > >> Il 30/06/2014 03:03, Nadav Amit ha scritto: >>>>> >>>>> sipi_vector = apic->sipi_vector; >>>>> - pr_debug("vcpu %d received sipi with vector # %x\n", >>>>> + apic_debug("vcpu %d received sipi with vector # %x\n", >>>> >>>> Why don't we just use pr_debug all throughout ? >>>> >>> I don't know. I just tried to make it consistent, since it really bugged >>> me while I was debugging the local-apic. >>> If you prefer the other way around (which does seem to be better), I can >>> do the search-and-replace. >> >> vcpu number probably could be moved inside apic_debug, at which point >> apic_debug becomes preferrable. > > I am not sure, I think all that could be achieved with a file private > debug define can be done with pr_debug which is generic. > Nadav didn't introduce apic_debug to this file, so I am > fine either way. I am applying the patch, anything else can be done on top. Paolo