From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH] arm64: KVM: export demux regids as KVM_REG_ARM64
Date: Tue, 01 Jul 2014 16:56:50 +0100
Message-ID: <53B2DA42.40604@arm.com>
References: <1404229993-14522-1-git-send-email-alex.bennee@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Christoffer Dall <christoffer.dall@linaro.org>,
	Gleb Natapov <gleb@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	open list <linux-kernel@vger.kernel.org>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1404229993-14522-1-git-send-email-alex.bennee@linaro.org>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 01/07/14 16:53, Alex Benn=C3=A9e wrote:
> I suspect this is a -ECUTPASTE fault from the initial implementation.=
 If
> we don't declare the register ID to be KVM_REG_ARM64 the KVM_GET_ONE_=
REG
> implementation kvm_arm_get_reg() returns -EINVAL and hilarity ensues.
>=20
> The kvm/api.txt document describes all arm64 registers as starting wi=
th
> 0x60xx... (i.e KVM_REG_ARM64).
>=20
> Signed-off-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
> Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
> ---
>  arch/arm64/kvm/sys_regs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
> index 0324458..5ee99e4 100644
> --- a/arch/arm64/kvm/sys_regs.c
> +++ b/arch/arm64/kvm/sys_regs.c
> @@ -962,7 +962,7 @@ static unsigned int num_demux_regs(void)
> =20
>  static int write_demux_regids(u64 __user *uindices)
>  {
> -	u64 val =3D KVM_REG_ARM | KVM_REG_SIZE_U32 | KVM_REG_ARM_DEMUX;
> +	u64 val =3D KVM_REG_ARM64 | KVM_REG_SIZE_U32 | KVM_REG_ARM_DEMUX;
>  	unsigned int i;
> =20
>  	val |=3D KVM_REG_ARM_DEMUX_ID_CCSIDR;
>=20

-EBROWNPAPERBAG.

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

Thanks,

	M.
--=20
Jazz is not dead. It just smells funny...