From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH 1/3] powerpc/kvm: Remove redundant save of SIER AND MMCR2 Date: Fri, 04 Jul 2014 09:57:21 +0200 Message-ID: <53B65E61.3070107@suse.de> References: <1404367956-19515-1-git-send-email-joel@jms.id.au> <1404367956-19515-2-git-send-email-joel@jms.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc , KVM To: Joel Stanley , paulus@samba.org, benh@kernel.crashing.org, mpe@ellerman.id.au Return-path: In-Reply-To: <1404367956-19515-2-git-send-email-joel@jms.id.au> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 03.07.14 08:12, Joel Stanley wrote: > These two registers are already saved in the block above. Aside from > being unnecessary, by the time we get down to the second save location > r8 no longer contains MMCR2, so we are clobbering the saved value with > PMC5. > > Signed-off-by: Joel Stanley Reviewed-by: Alexander Graf Please CC kvm-ppc@vger and kvm@vger when you send kvm related patches :). Ben, I think this patch makes sense to go via your tree. Want to take it? Alex > --- > arch/powerpc/kvm/book3s_hv_interrupts.S | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/powerpc/kvm/book3s_hv_interrupts.S b/arch/powerpc/kvm/book3s_hv_interrupts.S > index 8c86422..731be74 100644 > --- a/arch/powerpc/kvm/book3s_hv_interrupts.S > +++ b/arch/powerpc/kvm/book3s_hv_interrupts.S > @@ -127,11 +127,6 @@ BEGIN_FTR_SECTION > stw r10, HSTATE_PMC + 24(r13) > stw r11, HSTATE_PMC + 28(r13) > END_FTR_SECTION_IFSET(CPU_FTR_ARCH_201) > -BEGIN_FTR_SECTION > - mfspr r9, SPRN_SIER > - std r8, HSTATE_MMCR + 40(r13) > - std r9, HSTATE_MMCR + 48(r13) > -END_FTR_SECTION_IFSET(CPU_FTR_ARCH_207S) > 31: > > /*