From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH for-2.1] target-i386: Add "kvmclock-stable-bit" feature bit name Date: Sat, 05 Jul 2014 11:54:10 +0200 Message-ID: <53B7CB42.5060609@redhat.com> References: <1404503074-6381-1-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Igor Mammedov To: Eduardo Habkost , qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= , kvm@vger.kernel.org Return-path: Received: from mail-qa0-f53.google.com ([209.85.216.53]:33169 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754661AbaGEJyP (ORCPT ); Sat, 5 Jul 2014 05:54:15 -0400 Received: by mail-qa0-f53.google.com with SMTP id j15so1994683qaq.26 for ; Sat, 05 Jul 2014 02:54:14 -0700 (PDT) In-Reply-To: <1404503074-6381-1-git-send-email-ehabkost@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 04/07/2014 21:44, Eduardo Habkost ha scritto: > KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is enabled by default and supported > by KVM. But not having a name defined makes QEMU treat it as an unknown > and unmigratable feature flag (as any unknown feature may possibly > require state to be migrated), and disable it by default on "-cpu host". > > As a side-effect, the new name also makes the flag configurable, > allowing the user to disable it (which may be useful for testing or for > compatibility with old kernels). > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 45c662d..6d008ab 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -241,7 +241,7 @@ static const char *kvm_feature_name[] = { > NULL, NULL, NULL, NULL, > NULL, NULL, NULL, NULL, > NULL, NULL, NULL, NULL, > - NULL, NULL, NULL, NULL, > + "kvmclock-stable-bit", NULL, NULL, NULL, > NULL, NULL, NULL, NULL, > }; > > Applied to uq/master, thanks. Paolo