From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH] powerpc/kvm: Create proper names for the kvm_host_state
 PMU fields
Date: Thu, 10 Jul 2014 12:16:10 +0200
Message-ID: <53BE67EA.8000206@suse.de>
References: <1404984871-15145-1-git-send-email-mpe@ellerman.id.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Paul Mackerras <paulus@samba.org>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:60915 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750958AbaGJKQN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 10 Jul 2014 06:16:13 -0400
In-Reply-To: <1404984871-15145-1-git-send-email-mpe@ellerman.id.au>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


On 10.07.14 11:34, Michael Ellerman wrote:
> We have two arrays in kvm_host_state that contain register values for
> the PMU. Currently we only create an asm-offsets symbol for the base of
> the arrays, and do the array offset in the assembly code.
>
> Creating an asm-offsets symbol for each field individually makes the
> code much nicer to read, particularly for the MMCRx/SIxR/SDAR fields, and
> might have helped us notice the recent double restore bug we had in this
> code.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Acked-by: Alexander Graf <agraf@suse.de>

I still think this whole code path should just be C though.


Alex