From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>, Alok Kataria <akataria@vmware.com>
Cc: kvm@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
Gleb Natapov <gleb@kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
jmattson@vmware.com
Subject: Re: [PATCH v2] KVM: Synthesize G bit for all segments.
Date: Thu, 10 Jul 2014 14:27:24 +0200 [thread overview]
Message-ID: <53BE86AC.4090308@redhat.com> (raw)
In-Reply-To: <53BE551C.7090304@siemens.com>
Il 10/07/2014 10:55, Jan Kiszka ha scritto:
>> > + /*
>> > + * SVM spec doesn't require the platform to track the G bit for all
>> > + * segments, so similar to CS, let's synthesize this bit for all
>> > + * segments.
> Either I misunderstand the reference to CS or it does no longer apply
> once the patch is in. I would suggest to remove that part of the sentence.
Something like this:
/*
* The SVM spec doesn't require the platform to track the 'G' bit for
* all segments. Current processors track it for all segments except
* CS, but other hypervisors may not do so. So let's synthesize this
* bit always to help running KVM nested. It also helps cross-vendor
* migration, because Intel's vmentry has a check on the 'G' bit.
*/
Paolo
next prev parent reply other threads:[~2014-07-10 12:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 10:38 [RFC PATCH] KVM: Synthesize G bit for all segments Alok Kataria
2014-07-07 10:52 ` Jan Kiszka
2014-07-07 13:04 ` Paolo Bonzini
2014-07-08 4:17 ` [PATCH v2] " Alok Kataria
2014-07-10 8:55 ` Jan Kiszka
2014-07-10 12:27 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-11 7:08 Alok Kataria
2014-07-11 7:09 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BE86AC.4090308@redhat.com \
--to=pbonzini@redhat.com \
--cc=akataria@vmware.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=jmattson@vmware.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox