From: Tang Chen <tangchen@cn.fujitsu.com>
To: <gleb@kernel.org>, <mtosatti@redhat.com>, <nadav.amit@gmail.com>
Cc: Tang Chen <tangchen@cn.fujitsu.com>, <kvm@vger.kernel.org>,
<laijs@cn.fujitsu.com>, <isimatu.yasuaki@jp.fujitsu.com>,
<guz.fnst@cn.fujitsu.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/5] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page.
Date: Fri, 11 Jul 2014 14:23:52 +0800 [thread overview]
Message-ID: <53BF82F8.5070707@cn.fujitsu.com> (raw)
In-Reply-To: <1404824492-30095-1-git-send-email-tangchen@cn.fujitsu.com>
hi Gleb, Marcelo, Nadav,
Would you please help to review these patches ?
Thanks. :)
On 07/08/2014 09:01 PM, Tang Chen wrote:
> ept identity pagetable and apic access page in kvm are pinned in memory.
> As a result, they cannot be migrated/hot-removed.
>
> But actually they don't need to be pinned in memory.
>
> [For ept identity page]
> Just do not pin it. When it is migrated, guest will be able to find the
> new page in the next ept violation.
>
> [For apic access page]
> The hpa of apic access page is stored in VMCS APIC_ACCESS_ADDR pointer.
> When apic access page is migrated, we update VMCS APIC_ACCESS_ADDR pointer
> for each vcpu in addition.
>
> Change log v1 -> v2:
> 1. Add [PATCH 4/5] to remove unnecessary kvm_arch->ept_identity_pagetable.
> 2. In [PATCH 3/5], only introduce KVM_REQ_APIC_PAGE_RELOAD request.
> 3. In [PATCH 3/5], add set_apic_access_page_addr() for svm.
>
>
> Tang Chen (5):
> kvm: Add gfn_to_page_no_pin() to translate gfn to page without
> pinning.
> kvm: Use APIC_DEFAULT_PHYS_BASE macro as the apic access page address.
> kvm, mem-hotplug: Do not pin ept identity pagetable in memory.
> kvm: Remove ept_identity_pagetable from struct kvm_arch.
> kvm, mem-hotplug: Do not pin apic access page in memory.
>
> arch/x86/include/asm/kvm_host.h | 2 +-
> arch/x86/kvm/mmu.c | 11 +++++++++++
> arch/x86/kvm/svm.c | 9 ++++++++-
> arch/x86/kvm/vmx.c | 40 ++++++++++++++++++++++------------------
> arch/x86/kvm/x86.c | 16 ++++++++++++++--
> include/linux/kvm_host.h | 3 +++
> virt/kvm/kvm_main.c | 29 ++++++++++++++++++++++++++++-
> 7 files changed, 87 insertions(+), 23 deletions(-)
>
prev parent reply other threads:[~2014-07-11 6:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 13:01 [PATCH v2 0/5] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-07-08 13:01 ` [PATCH v2 1/5] kvm: Add gfn_to_page_no_pin() to translate gfn to page without pinning Tang Chen
2014-07-08 13:01 ` [PATCH v2 2/5] kvm: Use APIC_DEFAULT_PHYS_BASE macro as the apic access page address Tang Chen
2014-07-08 13:01 ` [PATCH v2 3/5] kvm, mem-hotplug: Do not pin ept identity pagetable in memory Tang Chen
2014-07-08 13:01 ` [PATCH v2 4/5] kvm: Remove ept_identity_pagetable from struct kvm_arch Tang Chen
2014-07-09 2:06 ` Tang Chen
2014-07-09 2:08 ` [RESEND PATCH " Tang Chen
2014-07-12 7:44 ` Gleb Natapov
2014-07-14 9:17 ` Tang Chen
2014-07-14 14:27 ` Gleb Natapov
2014-07-15 10:39 ` Tang Chen
2014-07-08 13:01 ` [PATCH v2 5/5] kvm, mem-hotplug: Do not pin apic access page in memory Tang Chen
2014-07-12 8:04 ` Gleb Natapov
2014-07-14 7:57 ` Tang Chen
2014-07-14 14:58 ` Gleb Natapov
2014-07-15 11:52 ` Jan Kiszka
2014-07-15 12:09 ` Gleb Natapov
2014-07-15 12:28 ` Tang Chen
2014-07-15 12:40 ` Gleb Natapov
2014-07-15 12:54 ` Tang Chen
2014-07-15 14:40 ` Gleb Natapov
2014-07-17 9:22 ` Tang Chen
2014-07-15 13:10 ` Jan Kiszka
2014-07-15 14:04 ` Gleb Natapov
2014-07-17 13:34 ` Tang Chen
2014-07-17 13:57 ` Gleb Natapov
2014-07-18 9:05 ` Tang Chen
2014-07-18 11:21 ` Gleb Natapov
2014-07-15 12:11 ` Tang Chen
2014-07-09 1:20 ` [PATCH v2 0/5] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-07-11 6:23 ` Tang Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BF82F8.5070707@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=gleb@kernel.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=nadav.amit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox