From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: svm: virtualize MSR reads from MC4_MISC1 Date: Fri, 11 Jul 2014 09:14:28 +0200 Message-ID: <53BF8ED4.3060909@redhat.com> References: <1403785327-1357-1-git-send-email-matthias.lange@kernkonzept.com> <1403785327-1357-2-git-send-email-matthias.lange@kernkonzept.com> <53BD6D2F.8070504@redhat.com> <20140710093123.GA20320@triton> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org, Gleb Natapov Return-path: Received: from mail-ie0-f178.google.com ([209.85.223.178]:61875 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbaGKHOd (ORCPT ); Fri, 11 Jul 2014 03:14:33 -0400 Received: by mail-ie0-f178.google.com with SMTP id tp5so531620ieb.23 for ; Fri, 11 Jul 2014 00:14:33 -0700 (PDT) In-Reply-To: <20140710093123.GA20320@triton> Sender: kvm-owner@vger.kernel.org List-ID: Il 10/07/2014 11:31, Matthias Lange ha scritto: > MC4_MISC0 (0x413) is handled in kvm_get_msr_common by this statement > > case MSR_IA32_MC0_CTL ... MSR_IA32_MC0_CTL + 4 * KVM_MAX_MCE_BANKS - 1: > return get_msr_mce(vcpu, msr, pdata); > > and get_msr_mce returns a sane value from the vcpu mce_banks. > Can you please add the MSR name to a .h file instead, and handle it in get_msr_mce? Paolo