* [RFC Patch V1 25/30] mm, x86, kvm: Use cpu_to_mem()/numa_mem_id() to support memoryless node [not found] <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com> @ 2014-07-11 7:37 ` Jiang Liu 2014-07-11 7:44 ` Paolo Bonzini 0 siblings, 1 reply; 2+ messages in thread From: Jiang Liu @ 2014-07-11 7:37 UTC (permalink / raw) To: Andrew Morton, Mel Gorman, David Rientjes, Mike Galbraith, Peter Zijlstra, Rafael J . Wysocki, Gleb Natapov, Paolo Bonzini, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86 Cc: Jiang Liu, Tony Luck, linux-mm, linux-hotplug, linux-kernel, kvm When CONFIG_HAVE_MEMORYLESS_NODES is enabled, cpu_to_node()/numa_node_id() may return a node without memory, and later cause system failure/panic when calling kmalloc_node() and friends with returned node id. So use cpu_to_mem()/numa_mem_id() instead to get the nearest node with memory for the/current cpu. If CONFIG_HAVE_MEMORYLESS_NODES is disabled, cpu_to_mem()/numa_mem_id() is the same as cpu_to_node()/numa_node_id(). Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> --- arch/x86/kvm/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 801332edefc3..beb7c6d5d51b 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -2964,7 +2964,7 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf) static struct vmcs *alloc_vmcs_cpu(int cpu) { - int node = cpu_to_node(cpu); + int node = cpu_to_mem(cpu); struct page *pages; struct vmcs *vmcs; -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC Patch V1 25/30] mm, x86, kvm: Use cpu_to_mem()/numa_mem_id() to support memoryless node 2014-07-11 7:37 ` [RFC Patch V1 25/30] mm, x86, kvm: Use cpu_to_mem()/numa_mem_id() to support memoryless node Jiang Liu @ 2014-07-11 7:44 ` Paolo Bonzini 0 siblings, 0 replies; 2+ messages in thread From: Paolo Bonzini @ 2014-07-11 7:44 UTC (permalink / raw) To: Jiang Liu, Andrew Morton, Mel Gorman, David Rientjes, Mike Galbraith, Peter Zijlstra, Rafael J . Wysocki, Gleb Natapov, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86 Cc: Tony Luck, linux-mm, linux-hotplug, linux-kernel, kvm Il 11/07/2014 09:37, Jiang Liu ha scritto: > When CONFIG_HAVE_MEMORYLESS_NODES is enabled, cpu_to_node()/numa_node_id() > may return a node without memory, and later cause system failure/panic > when calling kmalloc_node() and friends with returned node id. > So use cpu_to_mem()/numa_mem_id() instead to get the nearest node with > memory for the/current cpu. > > If CONFIG_HAVE_MEMORYLESS_NODES is disabled, cpu_to_mem()/numa_mem_id() > is the same as cpu_to_node()/numa_node_id(). > > Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com> > --- > arch/x86/kvm/vmx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index 801332edefc3..beb7c6d5d51b 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -2964,7 +2964,7 @@ static __init int setup_vmcs_config(struct vmcs_config *vmcs_conf) > > static struct vmcs *alloc_vmcs_cpu(int cpu) > { > - int node = cpu_to_node(cpu); > + int node = cpu_to_mem(cpu); > struct page *pages; > struct vmcs *vmcs; > > Acked-by: Paolo Bonzini <pbonzini@redhat.com> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-11 7:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com>
2014-07-11 7:37 ` [RFC Patch V1 25/30] mm, x86, kvm: Use cpu_to_mem()/numa_mem_id() to support memoryless node Jiang Liu
2014-07-11 7:44 ` Paolo Bonzini
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox