From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [PATCH 35/38] unicore32: clean-up uapi Kbuild file Date: Tue, 15 Jul 2014 11:53:52 +0100 Message-ID: <53C50840.2020204@imgtec.com> References: <20140714150609.GA28358@ravnborg.org> <1405350546-28467-1-git-send-email-sam@ravnborg.org> <1405350546-28467-35-git-send-email-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: lkml , linux-arch , Guan Xuetao , kvm To: Sam Ravnborg , Arnd Bergmann Return-path: In-Reply-To: <1405350546-28467-35-git-send-email-sam@ravnborg.org> Sender: linux-arch-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 14/07/14 16:09, Sam Ravnborg wrote: > Remove redundant assignments. > > Signed-off-by: Sam Ravnborg > Cc: Guan Xuetao > --- > arch/unicore32/include/uapi/asm/Kbuild | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/arch/unicore32/include/uapi/asm/Kbuild b/arch/unicore32/include/uapi/asm/Kbuild > index 0514d7a..aff532f 100644 > --- a/arch/unicore32/include/uapi/asm/Kbuild > +++ b/arch/unicore32/include/uapi/asm/Kbuild > @@ -1,10 +1,5 @@ > # UAPI Header export list > include include/uapi/asm-generic/Kbuild.asm > > -header-y += byteorder.h > -header-y += kvm_para.h > -header-y += ptrace.h > -header-y += sigcontext.h > -header-y += unistd.h > - > +# Wapper from asm-generic > generic-y += kvm_para.h > You dropped the generic-y += kvm_para.h for arm64 & c6x, but not for unicore, avr32 & ia64 patch, which seems a bit inconsistent. Was there some reason behind that? AFACT the non-uapi kvm_para.h is needed (e.g. by using the generic non-uapi one) by kernel/watchdog.c for kvm_check_and_clear_guest_paused(), so all arches should have at least generic-y += kvm_para.h (or their own one) for non-uapi, even if they have a uapi one too. For UAPI, they're presumably only needed for architectures which support KVM (s390, ia64, arm, powerpc, arm64, mips, x86 all provide an asm/kvm.h). Is that right? Clearly there's some cleanup to do for kvm_para.h (which is what made me look at the header issues previously). Cheers James