From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2 5/5] kvm, mem-hotplug: Do not pin apic access page in memory. Date: Tue, 15 Jul 2014 15:10:15 +0200 Message-ID: <53C52837.4030105@web.de> References: <1404824492-30095-1-git-send-email-tangchen@cn.fujitsu.com> <1404824492-30095-6-git-send-email-tangchen@cn.fujitsu.com> <20140712080442.GH4399@minantech.com> <53C38D55.2040307@cn.fujitsu.com> <20140714145822.GK4399@minantech.com> <53C51608.4080109@web.de> <20140715120921.GT18167@minantech.com> <53C51E66.7030208@cn.fujitsu.com> <20140715124048.GU18167@minantech.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ndPCTSEi3KP8GNFciBjsIURkx5bTXBXxf" Cc: mtosatti@redhat.com, nadav.amit@gmail.com, kvm@vger.kernel.org, laijs@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, guz.fnst@cn.fujitsu.com, linux-kernel@vger.kernel.org To: Gleb Natapov , Tang Chen Return-path: In-Reply-To: <20140715124048.GU18167@minantech.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ndPCTSEi3KP8GNFciBjsIURkx5bTXBXxf Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2014-07-15 14:40, Gleb Natapov wrote: >> >> ...... >> 7922 if (!vmx->nested.apic_access_page) >> 7923 exec_control &=3D >> 7924 ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; >> 7925 else >> 7926 vmcs_write64(APIC_ACCESS_ADDR, >> 7927 page_to_phys(vmx->nested.apic_access_page)); >> 7928 } else if >> (vm_need_virtualize_apic_accesses(vmx->vcpu.kvm)) { >> 7929 exec_control |=3D >> 7930 SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; >> 7931 vmcs_write64(APIC_ACCESS_ADDR, >> 7932 page_to_phys(vcpu->kvm->arch.apic_access_page)); >> 7933 } >> >> And yes, we have the problem you said here. We can migrate the page wh= ile L2 >> vm is running. >> So I think we should enforce L2 vm to exit to L1. Right ? >> > We can request APIC_ACCESS_ADDR reload during L2->L1 vmexit emulation, = so > if APIC_ACCESS_ADDR changes while L2 is running it will be reloaded for= L1 too. How should this host-managed VMCS field possibly change while L2 is runni= ng? Jan --ndPCTSEi3KP8GNFciBjsIURkx5bTXBXxf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlPFKDcACgkQitSsb3rl5xSrDACdG7B6LVBlptPxtgXqfiGBLqPJ 0f0AoJIkj+w1FOdKa+QZnqRUAfP+MIrC =EQGb -----END PGP SIGNATURE----- --ndPCTSEi3KP8GNFciBjsIURkx5bTXBXxf--