From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH] kvm: ppc: booke: Restore SPRG3 when entering guest Date: Thu, 17 Jul 2014 18:10:59 +0200 Message-ID: <53C7F593.2010804@suse.de> References: <1405490564-20119-1-git-send-email-Bharat.Bhushan@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, scottwood@freescale.com, stuart.yoder@freescale.com To: Bharat Bhushan , kvm-ppc@vger.kernel.org Return-path: In-Reply-To: <1405490564-20119-1-git-send-email-Bharat.Bhushan@freescale.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 16.07.14 08:02, Bharat Bhushan wrote: > SPRG3 is guest accessible and SPRG3 can be clobbered by host > or another guest, So this need to be restored when loading > guest state. > > Signed-off-by: Bharat Bhushan > --- > arch/powerpc/kvm/booke_interrupts.S | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/kvm/booke_interrupts.S b/arch/powerpc/kvm/booke_interrupts.S > index 2c6deb5ef..0d3403f 100644 > --- a/arch/powerpc/kvm/booke_interrupts.S > +++ b/arch/powerpc/kvm/booke_interrupts.S > @@ -459,6 +459,8 @@ lightweight_exit: > * written directly to the shared area, so we > * need to reload them here with the guest's values. > */ > + PPC_LD(r3, VCPU_SHARED_SPRG3, r5) > + mtspr SPRN_SPRG3, r3 We also need to restore it when resuming the host, no? Alex > PPC_LD(r3, VCPU_SHARED_SPRG4, r5) > mtspr SPRN_SPRG4W, r3 > PPC_LD(r3, VCPU_SHARED_SPRG5, r5)