From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH v2 1/2] contrib: add ivshmem client and server Date: Mon, 21 Jul 2014 17:26:16 +0200 Message-ID: <53CD3118.7060403@6wind.com> References: <1405849119-13569-1-git-send-email-david.marchand@6wind.com> <1405849119-13569-2-git-send-email-david.marchand@6wind.com> <53CD21E1.1010908@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, pbonzini@redhat.com, claudio.fontana@huawei.com, jani.kokkonen@huawei.com, cam@cs.ualberta.ca, Olivier Matz To: Eric Blake , qemu-devel@nongnu.org Return-path: Received: from mail-we0-f177.google.com ([74.125.82.177]:64712 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932455AbaGUP0V (ORCPT ); Mon, 21 Jul 2014 11:26:21 -0400 Received: by mail-we0-f177.google.com with SMTP id w62so7663231wes.8 for ; Mon, 21 Jul 2014 08:26:19 -0700 (PDT) In-Reply-To: <53CD21E1.1010908@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Hello Eric, On 07/21/2014 04:21 PM, Eric Blake wrote: > On 07/20/2014 03:38 AM, David Marchand wrote: >> +# Copyright 2014 6WIND S.A. >> +# All rights reserved > > This file has no other license, and is therefore incompatible with > GPLv2. You'll need to resubmit under an appropriately open license. missed the makefiles ... > >> +++ b/contrib/ivshmem-client/ivshmem-client.h >> @@ -0,0 +1,238 @@ >> +/* >> + * Copyright(c) 2014 6WIND S.A. >> + * All rights reserved. >> + * >> + * This work is licensed under the terms of the GNU GPL, version 2. See >> + * the COPYING file in the top-level directory. > > I'm not a lawyer, but to me, this license is self-contradictory. You > can't have "All rights reserved" and still be GPL, because the point of > the GPL is that you are NOT reserving all rights, but explicitly > granting your user various rights (on condition that they likewise grant > those rights to others). But you're not the only file in the qemu code > base with this questionable mix. > Hum, ok, will update. -- David Marchand