From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Xiao Guangrong <xiaoguangrong.eric@gmail.com>, mtosatti@redhat.com
Cc: kvm@vger.kernel.org, ak@linux.intel.com, pbonzini@redhat.com,
gleb@kernel.org, avi.kivity@gmail.com
Subject: Re: [patch 2/4] KVM: MMU: allow pinning spte translations (TDP-only)
Date: Tue, 22 Jul 2014 13:26:22 +0800 [thread overview]
Message-ID: <53CDF5FE.5080106@linux.vnet.ibm.com> (raw)
In-Reply-To: <F35E0BA1-FF86-4B62-9F94-AC7F25D9FD09@linux.vnet.ibm.com>
On 07/22/2014 05:46 AM, Xiao Guangrong wrote:
>> + if (is_pinned_spte(*sptep)) {
>> + /* don't nuke pinned sptes if page aging: return
>> + * young=yes instead.
>> + */
>> + if (age)
>> + return 1;
>> + mmu_reload_pinned_vcpus(kvm);
>> + }
>> drop_spte(kvm, step);
>
> This has a window between zapping spte and re-pin spte, so guest will fail
> at this time.
I got it, mmu_reload_pinned_vcpus will kick all vcpus out of guest and
pin the pages again... so it is ok. :)
next prev parent reply other threads:[~2014-07-22 5:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 19:12 [patch 0/4] KVM: support for pinning sptes (v2) mtosatti
2014-07-09 19:12 ` [patch 1/4] KVM: x86: add pinned parameter to page_fault methods mtosatti
2014-07-09 19:12 ` [patch 2/4] KVM: MMU: allow pinning spte translations (TDP-only) mtosatti
2014-07-17 17:18 ` Nadav Amit
2014-07-17 21:38 ` Marcelo Tosatti
2014-07-24 12:16 ` Nadav Amit
2014-07-21 21:46 ` Xiao Guangrong
2014-07-22 5:26 ` Xiao Guangrong [this message]
2014-07-09 19:12 ` [patch 3/4] KVM: MMU: reload request from GET_DIRTY_LOG path mtosatti
2014-07-21 13:14 ` Gleb Natapov
2014-09-09 15:28 ` Marcelo Tosatti
2014-09-22 17:19 ` Marcelo Tosatti
2014-09-30 18:59 ` Marcelo Tosatti
2014-10-04 7:23 ` Gleb Natapov
2014-10-06 17:19 ` Marcelo Tosatti
2014-10-08 6:56 ` Gleb Natapov
2014-10-08 17:15 ` Marcelo Tosatti
2014-10-08 17:59 ` Gleb Natapov
2014-10-08 19:22 ` Marcelo Tosatti
2014-10-10 13:09 ` Gleb Natapov
2014-10-13 8:52 ` Marcelo Tosatti
2014-10-15 8:03 ` Gleb Natapov
2014-07-21 21:55 ` Xiao Guangrong
2014-09-09 15:35 ` Marcelo Tosatti
2014-07-09 19:12 ` [patch 4/4] KVM: MMU: pinned sps are not candidates for deletion mtosatti
2014-07-21 21:59 ` Xiao Guangrong
2014-09-09 15:41 ` Marcelo Tosatti
2014-09-22 17:17 ` Marcelo Tosatti
2014-09-23 5:30 ` Xiao Guangrong
2014-07-09 19:20 ` [patch 0/4] KVM: support for pinning sptes (v2) Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CDF5FE.5080106@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=ak@linux.intel.com \
--cc=avi.kivity@gmail.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox