From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [GIT PULL 8/9] KVM: s390: advertise KVM_CAP_S390_IRQCHIP Date: Tue, 22 Jul 2014 20:21:29 +0200 Message-ID: <53CEABA9.9040706@de.ibm.com> References: <1405970065-3740-1-git-send-email-borntraeger@de.ibm.com> <1405970065-3740-9-git-send-email-borntraeger@de.ibm.com> <53CE218C.5020505@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Alexander Graf , KVM , linux-s390 , Cornelia Huck , Jens Freimann To: Paolo Bonzini Return-path: Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:44598 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbaGVSVg (ORCPT ); Tue, 22 Jul 2014 14:21:36 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 Jul 2014 19:21:35 +0100 In-Reply-To: <53CE218C.5020505@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 22/07/14 10:32, Paolo Bonzini wrote: > Il 21/07/2014 21:14, Christian Borntraeger ha scritto: >> From: Cornelia Huck >> >> We should advertise all capabilities, including those that can >> be enabled. >> >> Signed-off-by: Cornelia Huck >> Acked-by: Christian Borntraeger >> Signed-off-by: Christian Borntraeger >> --- >> arch/s390/kvm/kvm-s390.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c >> index dd902e6..339b34a 100644 >> --- a/arch/s390/kvm/kvm-s390.c >> +++ b/arch/s390/kvm/kvm-s390.c >> @@ -166,6 +166,7 @@ int kvm_dev_ioctl_check_extension(long ext) >> case KVM_CAP_IOEVENTFD: >> case KVM_CAP_DEVICE_CTRL: >> case KVM_CAP_ENABLE_CAP_VM: >> + case KVM_CAP_S390_IRQCHIP: >> case KVM_CAP_VM_ATTRIBUTES: >> case KVM_CAP_MP_STATE: >> r = 1; >> > > Should I apply this to 3.16 as well (or Cc: stable)? > Hmm, userspace currently does not care. But Cc: stable 3.15 and 3.16 might be "the right thing to do". Thanks for noticing. Christian