public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] KVM: PPC: fix incorrect way saving SPRN_MMCR2
@ 2014-07-23 11:52 Xiao Guangrong
  2014-07-24 13:09 ` Alexander Graf
  0 siblings, 1 reply; 3+ messages in thread
From: Xiao Guangrong @ 2014-07-23 11:52 UTC (permalink / raw)
  To: Alexander Graf; +Cc: Paul Mackerras, Paolo Bonzini, KVM

SPRN_SIER and SPRN_MMCR2 are doublely saved, particularly
SPRN_MMCR2 is oversaved with a incorrect value which comes
from SPRN_PMC5

Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
---
 arch/powerpc/kvm/book3s_hv_interrupts.S | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_hv_interrupts.S b/arch/powerpc/kvm/book3s_hv_interrupts.S
index 8c86422..731be74 100644
--- a/arch/powerpc/kvm/book3s_hv_interrupts.S
+++ b/arch/powerpc/kvm/book3s_hv_interrupts.S
@@ -127,11 +127,6 @@ BEGIN_FTR_SECTION
 	stw	r10, HSTATE_PMC + 24(r13)
 	stw	r11, HSTATE_PMC + 28(r13)
 END_FTR_SECTION_IFSET(CPU_FTR_ARCH_201)
-BEGIN_FTR_SECTION
-	mfspr	r9, SPRN_SIER
-	std	r8, HSTATE_MMCR + 40(r13)
-	std	r9, HSTATE_MMCR + 48(r13)
-END_FTR_SECTION_IFSET(CPU_FTR_ARCH_207S)
 31:

 	/*
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] KVM: PPC: fix incorrect way saving SPRN_MMCR2
  2014-07-23 11:52 [PATCH] KVM: PPC: fix incorrect way saving SPRN_MMCR2 Xiao Guangrong
@ 2014-07-24 13:09 ` Alexander Graf
  2014-07-24 16:20   ` Xiao Guangrong
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Graf @ 2014-07-24 13:09 UTC (permalink / raw)
  To: Xiao Guangrong; +Cc: Paul Mackerras, Paolo Bonzini, KVM


On 23.07.14 13:52, Xiao Guangrong wrote:
> SPRN_SIER and SPRN_MMCR2 are doublely saved, particularly
> SPRN_MMCR2 is oversaved with a incorrect value which comes
> from SPRN_PMC5
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>

This patch is already in upstream:

   f73128f4f680e8be68cda831f2710214559583cb


Alex


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] KVM: PPC: fix incorrect way saving SPRN_MMCR2
  2014-07-24 13:09 ` Alexander Graf
@ 2014-07-24 16:20   ` Xiao Guangrong
  0 siblings, 0 replies; 3+ messages in thread
From: Xiao Guangrong @ 2014-07-24 16:20 UTC (permalink / raw)
  To: Alexander Graf; +Cc: Paul Mackerras, Paolo Bonzini, KVM


On Jul 24, 2014, at 9:09 PM, Alexander Graf <agraf@suse.de> wrote:

> 
> On 23.07.14 13:52, Xiao Guangrong wrote:
>> SPRN_SIER and SPRN_MMCR2 are doublely saved, particularly
>> SPRN_MMCR2 is oversaved with a incorrect value which comes
>> from SPRN_PMC5
>> 
>> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
> 
> This patch is already in upstream:
> 
> f73128f4f680e8be68cda831f2710214559583cb

I was using kvm tree and did not find it on ‘queue’ branch, maybe i should
use your tree instead. Sorry for the noise and thanks for you check. :)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-07-24 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-23 11:52 [PATCH] KVM: PPC: fix incorrect way saving SPRN_MMCR2 Xiao Guangrong
2014-07-24 13:09 ` Alexander Graf
2014-07-24 16:20   ` Xiao Guangrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox