From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH 1/6 v2] kvm: ppc: bookehv: Added wrapper macros for shadow registers Date: Thu, 24 Jul 2014 17:04:37 +0200 Message-ID: <53D12085.7040609@suse.de> References: <1405596700-2699-1-git-send-email-Bharat.Bhushan@freescale.com> <1405596700-2699-2-git-send-email-Bharat.Bhushan@freescale.com> <1405644953.7714.54.camel@snotra.buserror.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, stuart.yoder@freescale.com To: Scott Wood , Bharat Bhushan Return-path: In-Reply-To: <1405644953.7714.54.camel@snotra.buserror.net> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 18.07.14 02:55, Scott Wood wrote: > On Thu, 2014-07-17 at 17:01 +0530, Bharat Bhushan wrote: >> There are shadow registers like, GSPRG[0-3], GSRR0, GSRR1 etc on >> BOOKE-HV and these shadow registers are guest accessible. >> So these shadow registers needs to be updated on BOOKE-HV. >> This patch adds new macro for get/set helper of shadow register . >> >> Signed-off-by: Bharat Bhushan >> --- >> v1->v2 >> - Fix compilation for book3s (separate macro etc) >> >> arch/powerpc/include/asm/kvm_ppc.h | 44 +++++++++++++++++++++++++++++++------- >> 1 file changed, 36 insertions(+), 8 deletions(-) >> >> diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h >> index f3f7611..7646994 100644 >> --- a/arch/powerpc/include/asm/kvm_ppc.h >> +++ b/arch/powerpc/include/asm/kvm_ppc.h >> @@ -475,8 +475,20 @@ static inline bool kvmppc_shared_big_endian(struct kvm_vcpu *vcpu) >> #endif >> } >> >> +#define SPRNG_WRAPPER_GET(reg, e500hv_spr) \ >> +static inline ulong kvmppc_get_##reg(struct kvm_vcpu *vcpu) \ >> +{ \ >> + return mfspr(e500hv_spr); \ >> +} \ >> + >> +#define SPRNG_WRAPPER_SET(reg, e500hv_spr) \ >> +static inline void kvmppc_set_##reg(struct kvm_vcpu *vcpu, ulong val) \ >> +{ \ >> + mtspr(e500hv_spr, val); \ >> +} \ > Why "e500hv" rather than "bookehv"? No good reason. Bharat, could you please send a quick patch to rename them? Alex