From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Auger Subject: Re: [PATCH 0/6] IRQFD without IRQ routing, enabled for XICS Date: Thu, 24 Jul 2014 17:47:26 +0200 Message-ID: <53D12A8E.6050407@linaro.org> References: <1404125474-18611-1-git-send-email-paulus@samba.org> <20140714161842.052bb423.cornelia.huck@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, "Michael S. Tsirkin" , Alexander Graf To: Cornelia Huck , Paul Mackerras Return-path: In-Reply-To: <20140714161842.052bb423.cornelia.huck@de.ibm.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Hi Paul, I also confirm your patch works fine on my ARM test environment. I was able to run - with irqchip without regression - without irqchip (ie removing routing totally), just implementing identity kvm_irq_map_gsi and kvm_irq_map_chip_pin and proper kvm_set_irq. The overall integration becomes much simpler :-) Many thanks Best Regards Eric On 07/14/2014 04:18 PM, Cornelia Huck wrote: > On Mon, 30 Jun 2014 20:51:08 +1000 > Paul Mackerras wrote: > >> I would like to see this go into 3.17. > > FWIW: I've given this a whirl on s390 (with a dataplane disk), and > everything seems to work as before. > > The only thing which is I think worth mentioning is that embedding the > routing entry into the irqfd struct will grow it a bit, which might be > noticable on large installations with hundreds of devices. OTOH, the > routing entry isn't too large, so I don't think it will become a > problem. > >> >> arch/ia64/kvm/Kconfig | 1 + >> arch/powerpc/kvm/Kconfig | 3 + >> arch/powerpc/kvm/book3s_hv_rm_xics.c | 5 ++ >> arch/powerpc/kvm/book3s_xics.c | 55 +++++++++++--- >> arch/powerpc/kvm/book3s_xics.h | 2 + >> arch/powerpc/kvm/mpic.c | 4 +- >> arch/s390/kvm/Kconfig | 1 + >> arch/s390/kvm/interrupt.c | 3 +- >> arch/x86/kvm/Kconfig | 1 + >> include/linux/kvm_host.h | 43 ++++------- >> virt/kvm/Kconfig | 3 + >> virt/kvm/eventfd.c | 134 ++++++++++++++++++++++++++--------- >> virt/kvm/irq_comm.c | 24 +++---- >> virt/kvm/irqchip.c | 98 ++++++++++--------------- >> virt/kvm/kvm_main.c | 2 +- >> 15 files changed, 227 insertions(+), 152 deletions(-) >