From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/4] x86/kvm: Resolve some missing-initializers warnings Date: Fri, 25 Jul 2014 16:04:59 +0200 Message-ID: <53D2640B.80600@redhat.com> References: <1406294825-21393-1-git-send-email-jeffrey.t.kirsher@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Mark Rustad , kvm@vger.kernel.org To: Jeff Kirsher , gleb@kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:32616 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760130AbaGYOFD (ORCPT ); Fri, 25 Jul 2014 10:05:03 -0400 In-Reply-To: <1406294825-21393-1-git-send-email-jeffrey.t.kirsher@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 25/07/2014 15:27, Jeff Kirsher ha scritto: > From: Mark Rustad > > Resolve some missing-initializers warnings that appear in W=2 > builds. They are resolved by using a designated initialization, > which is enough to resolve the warning. > > Signed-off-by: Mark Rustad > Signed-off-by: Jeff Kirsher > --- > arch/x86/kvm/x86.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index ef432f8..6d0f47208 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -82,8 +82,8 @@ u64 __read_mostly efer_reserved_bits = ~((u64)(EFER_SCE | EFER_LME | EFER_LMA)); > static u64 __read_mostly efer_reserved_bits = ~((u64)EFER_SCE); > #endif > > -#define VM_STAT(x) offsetof(struct kvm, stat.x), KVM_STAT_VM > -#define VCPU_STAT(x) offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU > +#define VM_STAT(x) .offset = offsetof(struct kvm, stat.x), KVM_STAT_VM > +#define VCPU_STAT(x) .offset = offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU > > static void update_cr8_intercept(struct kvm_vcpu *vcpu); > static void process_nmi(struct kvm_vcpu *vcpu); > This is really ugly. Either add the missing initializer (it's just a NULL) or, better, move the name into VM_STAT/VCPU_STAT and add the missing initializer to VM_STAT/VCPU_STAT. Paolo