From: Paolo Bonzini <pbonzini@redhat.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>, gleb@kernel.org
Cc: Mark Rustad <mark.d.rustad@intel.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 2/4] kvm: Resolve missing-field-initializers warnings
Date: Fri, 25 Jul 2014 16:06:00 +0200 [thread overview]
Message-ID: <53D26448.5020402@redhat.com> (raw)
In-Reply-To: <1406294825-21393-2-git-send-email-jeffrey.t.kirsher@intel.com>
Il 25/07/2014 15:27, Jeff Kirsher ha scritto:
> From: Mark Rustad <mark.d.rustad@intel.com>
>
> Resolve missing-field-initializers warnings seen in W=2 kernel
> builds by having macros generate more elaborated initializers.
> That is enough to silence the warnings.
>
> Signed-off-by: Mark Rustad <mark.d.rustad@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> virt/kvm/irq_comm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c
> index ced4a54..a228ee8 100644
> --- a/virt/kvm/irq_comm.c
> +++ b/virt/kvm/irq_comm.c
> @@ -323,13 +323,13 @@ out:
>
> #define IOAPIC_ROUTING_ENTRY(irq) \
> { .gsi = irq, .type = KVM_IRQ_ROUTING_IRQCHIP, \
> - .u.irqchip.irqchip = KVM_IRQCHIP_IOAPIC, .u.irqchip.pin = (irq) }
> + .u.irqchip = { .irqchip = KVM_IRQCHIP_IOAPIC, .pin = (irq) } }
> #define ROUTING_ENTRY1(irq) IOAPIC_ROUTING_ENTRY(irq)
>
> #ifdef CONFIG_X86
> # define PIC_ROUTING_ENTRY(irq) \
> { .gsi = irq, .type = KVM_IRQ_ROUTING_IRQCHIP, \
> - .u.irqchip.irqchip = SELECT_PIC(irq), .u.irqchip.pin = (irq) % 8 }
> + .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = (irq) % 8 } }
> # define ROUTING_ENTRY2(irq) \
> IOAPIC_ROUTING_ENTRY(irq), PIC_ROUTING_ENTRY(irq)
> #else
>
Applied.
Paolo
next prev parent reply other threads:[~2014-07-25 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 13:27 [PATCH 1/4] x86/kvm: Resolve some missing-initializers warnings Jeff Kirsher
2014-07-25 13:27 ` [PATCH 2/4] kvm: Resolve missing-field-initializers warnings Jeff Kirsher
2014-07-25 14:06 ` Paolo Bonzini [this message]
2014-07-25 13:27 ` [PATCH 3/4] x86/kvm: Resolve shadow warnings in macro expansion Jeff Kirsher
2014-07-25 14:06 ` Paolo Bonzini
2014-07-25 17:18 ` Rustad, Mark D
2014-07-26 7:34 ` Paolo Bonzini
2014-07-30 21:19 ` [PATCH V2 " Mark D Rustad
2014-07-31 11:50 ` Paolo Bonzini
2014-07-31 16:59 ` [PATCH V3 " Mark D Rustad
2014-07-25 13:27 ` [PATCH 4/4] x86/kvm: Resolve shadow warning from min macro Jeff Kirsher
2014-07-25 14:06 ` Paolo Bonzini
2014-07-25 14:04 ` [PATCH 1/4] x86/kvm: Resolve some missing-initializers warnings Paolo Bonzini
2014-07-30 21:18 ` [PATCH V2 " Mark D Rustad
2014-07-31 11:50 ` Paolo Bonzini
2014-07-31 16:35 ` Rustad, Mark D
2014-07-31 16:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D26448.5020402@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox