From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 2/4] kvm: Resolve missing-field-initializers warnings Date: Fri, 25 Jul 2014 16:06:00 +0200 Message-ID: <53D26448.5020402@redhat.com> References: <1406294825-21393-1-git-send-email-jeffrey.t.kirsher@intel.com> <1406294825-21393-2-git-send-email-jeffrey.t.kirsher@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Mark Rustad , kvm@vger.kernel.org To: Jeff Kirsher , gleb@kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38119 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760499AbaGYOGG (ORCPT ); Fri, 25 Jul 2014 10:06:06 -0400 In-Reply-To: <1406294825-21393-2-git-send-email-jeffrey.t.kirsher@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 25/07/2014 15:27, Jeff Kirsher ha scritto: > From: Mark Rustad > > Resolve missing-field-initializers warnings seen in W=2 kernel > builds by having macros generate more elaborated initializers. > That is enough to silence the warnings. > > Signed-off-by: Mark Rustad > Signed-off-by: Jeff Kirsher > --- > virt/kvm/irq_comm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c > index ced4a54..a228ee8 100644 > --- a/virt/kvm/irq_comm.c > +++ b/virt/kvm/irq_comm.c > @@ -323,13 +323,13 @@ out: > > #define IOAPIC_ROUTING_ENTRY(irq) \ > { .gsi = irq, .type = KVM_IRQ_ROUTING_IRQCHIP, \ > - .u.irqchip.irqchip = KVM_IRQCHIP_IOAPIC, .u.irqchip.pin = (irq) } > + .u.irqchip = { .irqchip = KVM_IRQCHIP_IOAPIC, .pin = (irq) } } > #define ROUTING_ENTRY1(irq) IOAPIC_ROUTING_ENTRY(irq) > > #ifdef CONFIG_X86 > # define PIC_ROUTING_ENTRY(irq) \ > { .gsi = irq, .type = KVM_IRQ_ROUTING_IRQCHIP, \ > - .u.irqchip.irqchip = SELECT_PIC(irq), .u.irqchip.pin = (irq) % 8 } > + .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = (irq) % 8 } } > # define ROUTING_ENTRY2(irq) \ > IOAPIC_ROUTING_ENTRY(irq), PIC_ROUTING_ENTRY(irq) > #else > Applied. Paolo