From: Joel Schopp <joel.schopp@amd.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Will Deacon <will.deacon@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"gleb@kernel.org" <gleb@kernel.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
kvm-devel <kvm@vger.kernel.org>,
Christoffer Dall <christoffer.dall@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Don Dutile <ddutile@redhat.com>
Subject: Re: [PATCH v2] kvm: arm64: vgic: fix hyp panic with 64k pages on juno platform
Date: Fri, 25 Jul 2014 11:24:18 -0500 [thread overview]
Message-ID: <53D284B2.60204@amd.com> (raw)
In-Reply-To: <CAFEAcA_aMg=TY8M_V5s9r4+w2jf_5N2-xO3m99TffgJVZ7mA5w@mail.gmail.com>
On 07/25/2014 11:02 AM, Peter Maydell wrote:
> On 25 July 2014 16:56, Joel Schopp <joel.schopp@amd.com> wrote:
>> The problem with this patch is the gicv is really 8K. The reason you
>> would map at a 60K offset (0xf000), and why we do on our SOC, is so that
>> the 8K gicv would pick up the last 4K from the first page and the first
>> 4K from the next page. With your patch it is impossible to map all 8K
>> of the gicv with 64K pages.
>>
>> My SOC which works fine with kvm now will go to not working with kvm
>> after this patch.
> Your SOC currently works by fluke because the guest doesn't
> look at the last 4K of the GICC. If you're happy with it continuing
> to work by fluke you could make your device tree say it had a
> 64K GICV region with a 64K-aligned base.
>
> To make it work not by fluke but actually correctly requires
> Marc's patchset, at a minimum.
Since we aren't actually using the last 4K of the gicv at the moment I supppose I could drop my objections to this patch and change my device tree until Marc's patchset provides a proper solution for the gicv's second 4K that works for everybody.
Acked-by: Joel Schopp <joel.schopp@amd.com>
next prev parent reply other threads:[~2014-07-25 16:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 15:29 [PATCH v2] kvm: arm64: vgic: fix hyp panic with 64k pages on juno platform Will Deacon
2014-07-25 15:56 ` Joel Schopp
2014-07-25 16:02 ` Peter Maydell
2014-07-25 16:24 ` Joel Schopp [this message]
2014-07-25 16:38 ` Will Deacon
2014-07-25 16:09 ` Will Deacon
2014-07-30 10:47 ` Marc Zyngier
2014-07-30 12:55 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D284B2.60204@amd.com \
--to=joel.schopp@amd.com \
--cc=christoffer.dall@linaro.org \
--cc=ddutile@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox