From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm Date: Mon, 28 Jul 2014 15:43:21 +0200 Message-ID: <53D65379.3040103@suse.de> References: <1404997839-29038-1-git-send-email-borntraeger@de.ibm.com> <20140710151431.0b7e3c34@thinkpad-w530> <20140710152738.767002d4@thinkpad-w530> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM , qemu-devel , Paolo Bonzini , linux-s390 , Cornelia Huck , Jens Freimann To: David Hildenbrand , Christian Borntraeger Return-path: Received: from cantor2.suse.de ([195.135.220.15]:53128 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbaG1Nna (ORCPT ); Mon, 28 Jul 2014 09:43:30 -0400 In-Reply-To: <20140710152738.767002d4@thinkpad-w530> Sender: kvm-owner@vger.kernel.org List-ID: On 10.07.14 15:27, David Hildenbrand wrote: >>> This is the qemu part of kernel series "Let user space control the >>> cpu states" >>> >>> Christian Borntraeger (1): >>> update linux headers with with cpustate changes >>> >>> David Hildenbrand (4): >>> s390x/kvm: introduce proper states for s390 cpus >>> s390x/kvm: proper use of the cpu states OPERATING and STOPPED >>> s390x/kvm: test whether a cpu is STOPPED when checking "has_work" >>> s390x/kvm: propagate s390 cpu state to kvm >>> >>> hw/s390x/ipl.c | 2 +- >>> hw/s390x/s390-virtio.c | 32 -------------- >>> linux-headers/linux/kvm.h | 7 ++- >>> target-s390x/cpu.c | 106 +++++++++++++++++++++++++++++++++++++++------- >>> target-s390x/cpu.h | 33 +++++++++++++-- >>> target-s390x/helper.c | 11 ++--- >>> target-s390x/kvm.c | 49 ++++++++++++++++++--- >>> trace-events | 6 +++ >>> 8 files changed, 179 insertions(+), 67 deletions(-) >>> >> Looks good to me >> >> -- >> To unsubscribe from this list: send the line "unsubscribe kvm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > @all thought it was the final internal review :) It's a perfectly good thing to say "looks good to me" in public too. The only major difference is that usually you would say "reviewed-by" ;). Alex