From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH/RFC 4/5] s390x/kvm: test whether a cpu is STOPPED when checking "has_work" Date: Mon, 28 Jul 2014 15:49:06 +0200 Message-ID: <53D654D2.40308@suse.de> References: <1404997839-29038-1-git-send-email-borntraeger@de.ibm.com> <1404997839-29038-5-git-send-email-borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Paolo Bonzini , linux-s390 , Cornelia Huck , Jens Freimann , David Hildenbrand To: Christian Borntraeger , KVM , qemu-devel Return-path: Received: from cantor2.suse.de ([195.135.220.15]:53266 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbaG1NtJ (ORCPT ); Mon, 28 Jul 2014 09:49:09 -0400 In-Reply-To: <1404997839-29038-5-git-send-email-borntraeger@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10.07.14 15:10, Christian Borntraeger wrote: > From: David Hildenbrand > > If a cpu is stopped, it must never be allowed to run and no interrupt may wake it > up. A cpu also has to be unhalted if it is halted and has work to do - this > scenario wasn't hit in kvm case yet, as only "disabled wait" is processed within > QEMU. > > Signed-off-by: David Hildenbrand > Reviewed-by: Cornelia Huck > Reviewed-by: Christian Borntraeger > Signed-off-by: Christian Borntraeger This looks like it's something that generic infrastructure should take care of, no? How does this work for the other archs? They always get an interrupt on the transition between !has_work -> has_work. Why don't we get one for s390x? Alex