From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Subject: Re: [PATCH] KVM: MMU: Use hashtable for MMU page hash
Date: Tue, 05 Aug 2014 12:00:02 +0800
Message-ID: <53E056C2.9070101@linux.vnet.ibm.com>
References: <1407185689-27727-1-git-send-email-sasha.levin@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
To: Sasha Levin <sasha.levin@oracle.com>, gleb@kernel.org,
	pbonzini@redhat.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1407185689-27727-1-git-send-email-sasha.levin@oracle.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 08/05/2014 04:54 AM, Sasha Levin wrote:
> Use the kernel hashtable interface instead of the hlist interface.
> This allows us to eliminate some unneeded code and make the code
> simpler.

The side effect is that the hash function is changed, the current
way is:
	gfn & ((1 << KVM_MMU_HASH_SHIFT) - 1);

Guest memory is always continuous and big region, i guess it's better
than the one you introduced.

Anyway, benchmark is needed and always welcome. :)