From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nadav Amit <nadav.amit@gmail.com>
Subject: Re: [PATCH v2 4/4] KVM: x86: Clear CR2 on VCPU reset
Date: Tue, 14 Apr 2015 13:31:19 +0300
Message-ID: <53E2F10B-0F2B-40FC-9B60-179264FE908D@gmail.com>
References: <1427933438-12782-1-git-send-email-namit@cs.technion.ac.il> <1427933438-12782-5-git-send-email-namit@cs.technion.ac.il> <20150414100326.GA4101@kernel>
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Nadav Amit <namit@cs.technion.ac.il>, pbonzini@redhat.com,
	kvm@vger.kernel.org
To: Wanpeng Li <wanpeng.li@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wi0-f174.google.com ([209.85.212.174]:37708 "EHLO
	mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753503AbbDNKbX convert rfc822-to-8bit (ORCPT
	<rfc822;kvm@vger.kernel.org>); Tue, 14 Apr 2015 06:31:23 -0400
Received: by widdi4 with SMTP id di4so16190122wid.0
        for <kvm@vger.kernel.org>; Tue, 14 Apr 2015 03:31:22 -0700 (PDT)
In-Reply-To: <20150414100326.GA4101@kernel>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Wanpeng Li <wanpeng.li@linux.intel.com> wrote:

> Hi Nadav,
> On Thu, Apr 02, 2015 at 03:10:38AM +0300, Nadav Amit wrote:
>> CR2 is not cleared as it should after reset.  See Intel SDM table na=
med "IA-32
>> Processor States Following Power-up, Reset, or INIT".
>=20
> How you trigger the reset instead of the "Power-up" one?

I sent an IPI of INIT for the KVM =E2=80=9Creset=E2=80=9D flow. I poste=
d a unit-test:
http://www.spinics.net/lists/kvm/msg115525.html

The actual reset is handled by qemu, but KVM is still able to introduce=
 bugs
in it, as it did in not reseting DR0-DR3.

Nadav