From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 5/6] KVM: trace kvm_ple_window Date: Thu, 21 Aug 2014 10:29:26 +0200 Message-ID: <53F5ADE6.30106@redhat.com> References: <1408567997-21222-1-git-send-email-rkrcmar@redhat.com> <1408567997-21222-6-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, Gleb Natapov , Raghavendra KT , Vinod Chegu , Hui-Zhi , Christian Borntraeger To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , kvm@vger.kernel.org Return-path: Received: from mail-we0-f174.google.com ([74.125.82.174]:63322 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbaHUI3c (ORCPT ); Thu, 21 Aug 2014 04:29:32 -0400 In-Reply-To: <1408567997-21222-6-git-send-email-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 20/08/2014 22:53, Radim Kr=C4=8Dm=C3=A1=C5=99 ha scritto: > Tracepoint for dynamic PLE window, fired on every potential change. >=20 > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > --- > arch/x86/kvm/trace.h | 25 +++++++++++++++++++++++++ > arch/x86/kvm/vmx.c | 8 +++++--- > arch/x86/kvm/x86.c | 1 + > 3 files changed, 31 insertions(+), 3 deletions(-) >=20 > diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h > index e850a7d..4b8e6cb 100644 > --- a/arch/x86/kvm/trace.h > +++ b/arch/x86/kvm/trace.h > @@ -848,6 +848,31 @@ TRACE_EVENT(kvm_track_tsc, > __print_symbolic(__entry->host_clock, host_clocks)) > ); > =20 > +TRACE_EVENT(kvm_ple_window, > + TP_PROTO(int grow, unsigned int vcpu_id, int new, int old), s/int grow/bool grow/ (and similarly in TP_STRUCT__entry). > + TP_ARGS(grow, vcpu_id, new, old), > + > + TP_STRUCT__entry( > + __field( int, grow ) > + __field( unsigned int, vcpu_id ) > + __field( int, new ) > + __field( int, old ) > + ), > + > + TP_fast_assign( > + __entry->grow =3D grow; > + __entry->vcpu_id =3D vcpu_id; > + __entry->new =3D new; > + __entry->old =3D old; > + ), > + > + TP_printk("vcpu %u: ple_window %d %s %d", > + __entry->vcpu_id, > + __entry->new, > + __entry->grow ? "<+" : "<-", ? "grow" : "shrink" With these changes, Reviewed-by: Paolo Bonzini Paolo > + __entry->old) > +); > + > #endif /* CONFIG_X86_64 */ > =20 > #endif /* _TRACE_KVM_H */ > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index e63d7ac..f63ac5d 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -5728,15 +5728,17 @@ static int __shrink_ple_window(int val, int s= hrinker, int minimum) > static void modify_ple_window(struct kvm_vcpu *vcpu, int grow) > { > struct vcpu_vmx *vmx =3D to_vmx(vcpu); > + int old =3D vmx->ple_window; > int new; > =20 > if (grow) > - new =3D __grow_ple_window(vmx->ple_window); > + new =3D __grow_ple_window(old) > else > - new =3D __shrink_ple_window(vmx->ple_window, ple_window_shrink, > - ple_window); > + new =3D __shrink_ple_window(old, ple_window_shrink, ple_window); > =20 > vmx->ple_window =3D max(new, ple_window); > + > + trace_kvm_ple_window(grow, vcpu->vcpu_id, vmx->ple_window, old); > } > #define grow_ple_window(vcpu) modify_ple_window(vcpu, 1) > #define shrink_ple_window(vcpu) modify_ple_window(vcpu, 0) > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 5696ee7..814b20c 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -7648,3 +7648,4 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_invlpga); > EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_skinit); > EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_nested_intercepts); > EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_write_tsc_offset); > +EXPORT_TRACEPOINT_SYMBOL_GPL(kvm_ple_window); >=20