From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 4/6] KVM: VMX: dynamise PLE window
Date: Thu, 21 Aug 2014 15:18:50 +0200
Message-ID: <53F5F1BA.3090306@redhat.com>
References: <1408567997-21222-1-git-send-email-rkrcmar@redhat.com> <1408567997-21222-5-git-send-email-rkrcmar@redhat.com> <53F5AD3E.3050800@redhat.com> <20140821115405.GD20546@potion.brq.redhat.com> <53F5E623.5090906@redhat.com> <20140821124223.GD20453@potion.brq.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Gleb Natapov <gleb@kernel.org>,
	Raghavendra KT <raghavendra.kt@linux.vnet.ibm.com>,
	Vinod Chegu <chegu_vinod@hp.com>,
	Hui-Zhi <hui-zhi.zhao@hp.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20140821124223.GD20453@potion.brq.redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Il 21/08/2014 14:42, Radim Kr=C4=8Dm=C3=A1=C5=99 ha scritto:
> 2014-08-21 14:29+0200, Paolo Bonzini:
>> Il 21/08/2014 13:54, Radim Kr=C4=8Dm=C3=A1=C5=99 ha scritto:
>>> Guity as charged.
>>> Using 0/1 or true/false in this context directly would be pretty ba=
d ...
>>> Is enum fine? (SHIRINK_PLE_WINDOW, GROW_PLE_WINDOW?)
>>
>> I prefer good old Ctrl-C Ctrl-V (adjusted for your favorite editor).=
 :)
>=20
> I, I should be able to do it, but nightmares are going to last a whil=
e.
>=20
> (And to lower chances of v4: are tracepoint macros, like for kvm_apic=
,
>  frowned upon now?)

Nah, go ahead.  But is there any example of #define like what you were
doing?  I tried grepping for "#define.*[a-z]\(" and didn't get anything
similar.

Paolo